Skip to content

Add a Link New Device screen (behind a feature flag). #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pixlwave merged 4 commits into from
Dec 11, 2025
Merged

Add a Link New Device screen (behind a feature flag). #4811

pixlwave merged 4 commits into from
Dec 11, 2025

Conversation

@pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 3, 2025

This PR makes the following changes:

  • Add a new button in the Settings screen to link a new device.
  • Add a Link New Device screen that asks the user whether they're linking a phone or a computer (which determines whether we show a QR code or scan one.

@pixlwave pixlwave requested a review from a team as a code owner December 3, 2025 15:25
@pixlwave pixlwave requested review from Velin92 and removed request for a team December 3, 2025 15:25
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 3, 2025
pixlwave
pixlwave commented Dec 3, 2025
View reviewed changes
ElementX/Resources/Localizations/en.lproj/Untranslated.strings
Copy link
Member Author

@pixlwave pixlwave Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in the next commit and I'll squash on merge so did seem worthwhile editing this commit.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ceb0cd6

@codecov
Copy link

codecov bot commented Dec 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.95122% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.55%. Comparing base (d130dff) to head (ceb0cd6).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...wDeviceScreen/LinkNewDeviceScreenCoordinator.swift 0.00% 27 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 22 Missing ⚠️
.../Settings/SettingsScreen/View/SettingsScreen.swift 12.50% 7 Missing ⚠️
...NewDeviceScreen/LinkNewDeviceScreenViewModel.swift 86.48% 5 Missing ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 3 Missing ⚠️
...LinkNewDeviceScreen/View/LinkNewDeviceScreen.swift 98.50% 2 Missing ⚠️
...ngs/SettingsScreen/SettingsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...tings/SettingsScreen/SettingsScreenViewModel.swift 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4811      +/-   ##
===========================================
- Coverage    79.58%   79.55%   -0.04%     
===========================================
  Files          884      888       +4     
  Lines        84958    85206     +248     
===========================================
+ Hits         67616    67782     +166     
- Misses       17342    17424      +82
Flag Coverage Δ
unittests 71.52% <71.95%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/link-new-device-screen branch from d0c2b68 to caa18c7 Compare December 3, 2025 16:00
@pixlwave pixlwave marked this pull request as draft December 3, 2025 16:18
@pixlwave
Copy link
Member Author

pixlwave commented Dec 3, 2025

Converting to draft while waiting for the PR in the SDK.

@pixlwave pixlwave force-pushed the doug/link-new-device-screen branch 2 times, most recently from c8b629d to 4ab5ff2 Compare December 10, 2025 10:43
@pixlwave pixlwave marked this pull request as ready for review December 10, 2025 10:44
@pixlwave pixlwave marked this pull request as draft December 10, 2025 11:35
@pixlwave pixlwave force-pushed the doug/link-new-device-screen branch 2 times, most recently from fd073d7 to e961770 Compare December 10, 2025 17:15
@pixlwave pixlwave marked this pull request as ready for review December 10, 2025 17:16
@pixlwave pixlwave force-pushed the doug/link-new-device-screen branch from e961770 to 2b865db Compare December 10, 2025 17:18
@pixlwave pixlwave mentioned this pull request Dec 10, 2025
Merged
@pixlwave pixlwave force-pushed the doug/link-new-device-screen branch from 2b865db to 38d85ea Compare December 10, 2025 18:35
Velin92
Velin92 reviewed Dec 11, 2025
View reviewed changes
Velin92
Velin92 reviewed Dec 11, 2025
View reviewed changes
@pixlwave pixlwave requested a review from Velin92 December 11, 2025 10:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pixlwave pixlwave merged commit 4ea1aae into develop Dec 11, 2025
14 checks passed
@pixlwave pixlwave deleted the doug/link-new-device-screen branch December 11, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees

No one assigned

Labels

pr-wip for anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pixlwave @Velin92