Remove eraseToStream now that any AsyncSequence is available to us.
#4836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 1d60bc2 |
pixlwave
force-pushed
the
doug/any-async-sequence
branch
from
ecc58ce to
540a5fd
Compare
pixlwave
changed the base branch from
doug/link-new-device-screen
to
develop
# Conflicts: # ElementX/Sources/Screens/LinkNewDeviceScreen/View/LinkNewDeviceScreen.swift
pixlwave
force-pushed
the
doug/any-async-sequence
branch
from
540a5fd to
1d60bc2
Compare
Velin92
requested changes
Dec 10, 2025
|
Velin92
approved these changes
Dec 10, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4836 +/- ##
===========================================
+ Coverage 79.55% 79.70% +0.15%
===========================================
Files 884 884
Lines 84969 84550 -419
===========================================
- Hits 67599 67394 -205
+ Misses 17370 17156 -214
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR silences some deprecation warnings, the main one being that we no longer need to use
eraseToStreamnow that we've dropped iOS 17 asany AsyncSequenceis now available to us. I decided not to also jump onto theObservationsbandwagon just yet, as I'd like to see if this is stable on CI and not make the 2 changes at once (given we previously triedObservationsand reverted it pretty quickly).Can be reviewed commit-by-commit.