Skip to content

Fix query parameters incorrectly typed as scalars #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 7, 2025
+83 −48
Merged

Fix query parameters incorrectly typed as scalars #5606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac7e53f
Fix query parameters incorrectly typed as scalars
pquentin Nov 4, 2025
8dd0dd1
Fix cluster.get_component_template
pquentin Nov 5, 2025
9ec44a1
Run make contrib
pquentin Nov 5, 2025
da2ef96
Stop relying on GitHub cache to validate APIs
pquentin Nov 5, 2025
aa28d9b
Use string | string[] instead of Names
pquentin Nov 6, 2025
0c5e97b
Merge branch 'main' into query-parameters-scalars
pquentin Nov 6, 2025
61c8a72
Run prettier
pquentin Nov 6, 2025
95566e3
Fix terms_enum too
pquentin Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions output/openapi/elasticsearch-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 13 additions & 3 deletions output/openapi/elasticsearch-serverless-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 29 additions & 14 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion specification/_global/field_caps/FieldCapabilitiesRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export interface Request extends RequestBase {
* @availability stack since=8.2.0
* @availability serverless
*/
filters?: string
filters?: string | string[]
Copy link
Member Author

@pquentin pquentin Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/elasticsearch/blob/bb71252622bf967fc0a8093278e92b87379bc2c5/server/src/main/java/org/elasticsearch/rest/action/RestFieldCapabilitiesAction.java#L70

/**
* A comma-separated list of field types to include.
* Any fields that do not match one of these types will be excluded from the results.
Expand Down
4 changes: 2 additions & 2 deletions specification/_global/terms_enum/TermsEnumRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import { RequestBase } from '@_types/Base'
import { Field, IndexName } from '@_types/common'
import { Field, Indices } from '@_types/common'
import { integer } from '@_types/Numeric'
import { QueryContainer } from '@_types/query_dsl/abstractions'
import { Duration } from '@_types/Time'
Expand Down Expand Up @@ -50,7 +50,7 @@ export interface Request extends RequestBase {
* Wildcard (`*`) expressions are supported.
* To search all data streams or indices, omit this parameter or use `*` or `_all`.
*/
index: IndexName
index: Indices
}
body: {
/** The string to match at the start of indexed terms. If not provided, all terms in the field are considered. */
Expand Down
4 changes: 2 additions & 2 deletions specification/indices/add_block/IndicesAddBlockRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import { RequestBase } from '@_types/Base'
import { ExpandWildcards, IndexName } from '@_types/common'
import { ExpandWildcards, Indices } from '@_types/common'
import { Duration } from '@_types/Time'
import { IndicesBlockOptions } from '@indices/_types/IndexSettings'

Expand Down Expand Up @@ -46,7 +46,7 @@ export interface Request extends RequestBase {
* To allow the adding of blocks to indices with `_all`, `*`, or other wildcard expressions, change the `action.destructive_requires_name` setting to `false`.
* You can update this setting in the `elasticsearch.yml` file or by using the cluster update settings API.
*/
index: IndexName
index: Indices
Copy link
Member Author

@pquentin pquentin Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/elasticsearch/blob/bb71252622bf967fc0a8093278e92b87379bc2c5/server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestAddIndexBlockAction.java#L47

/**
* The block type to add to the index.
*/
Expand Down
4 changes: 2 additions & 2 deletions specification/indices/data_streams_stats/IndicesDataStreamsStatsRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import { RequestBase } from '@_types/Base'
import { ExpandWildcards, IndexName } from '@_types/common'
import { ExpandWildcards, Indices } from '@_types/common'

/**
* Get data stream stats.
Expand Down Expand Up @@ -48,7 +48,7 @@ export interface Request extends RequestBase {
* Wildcard expressions (`*`) are supported.
* To target all data streams in a cluster, omit this parameter or use `*`.
*/
name?: IndexName
name?: Indices
Copy link
Member Author

@pquentin pquentin Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/elasticsearch/blob/bb71252622bf967fc0a8093278e92b87379bc2c5/modules/data-streams/src/main/java/org/elasticsearch/datastreams/rest/RestDataStreamsStatsAction.java#L41

}
query_parameters: {
/**
Expand Down
4 changes: 2 additions & 2 deletions specification/indices/remove_block/IndicesRemoveBlockRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import { RequestBase } from '@_types/Base'
import { ExpandWildcards, IndexName } from '@_types/common'
import { ExpandWildcards, Indices } from '@_types/common'
import { Duration } from '@_types/Time'
import { IndicesBlockOptions } from '@indices/_types/IndexSettings'

Expand Down Expand Up @@ -47,7 +47,7 @@ export interface Request extends RequestBase {
* To allow the removal of blocks from indices with `_all`, `*`, or other wildcard expressions, change the `action.destructive_requires_name` setting to `false`.
* You can update this setting in the `elasticsearch.yml` file or by using the cluster update settings API.
*/
index: IndexName
index: Indices
Copy link
Member Author

@pquentin pquentin Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/elasticsearch/blob/bb71252622bf967fc0a8093278e92b87379bc2c5/server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestRemoveIndexBlockAction.java#L50

/**
* The block type to remove from the index.
*/
Expand Down
4 changes: 2 additions & 2 deletions specification/security/clear_cached_privileges/SecurityClearCachedPrivilegesRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import { RequestBase } from '@_types/Base'
import { Name } from '@_types/common'
import { Names } from '@_types/common'

/**
* Clear the privileges cache.
Expand All @@ -44,6 +44,6 @@ export interface Request extends RequestBase {
* To clear all applications, use an asterism (`*`).
* It does not support other wildcard patterns.
*/
application: Name
application: Names
Copy link
Member Author

@pquentin pquentin Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/elasticsearch/blob/bb71252622bf967fc0a8093278e92b87379bc2c5/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/rest/action/role/RestClearRolesCacheAction.java#L43

}
}
Loading