Fix query parameters incorrectly typed as scalars #5606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
pquentin
commented
Nov 5, 2025
| * @availability serverless | ||
| */ | ||
| filters?: string | ||
| filters?: string | string[] |
| * You can update this setting in the `elasticsearch.yml` file or by using the cluster update settings API. | ||
| */ | ||
| index: IndexName | ||
| index: Indices |
| * To target all data streams in a cluster, omit this parameter or use `*`. | ||
| */ | ||
| name?: IndexName | ||
| name?: Indices |
| * You can update this setting in the `elasticsearch.yml` file or by using the cluster update settings API. | ||
| */ | ||
| index: IndexName | ||
| index: Indices |
| * It does not support other wildcard patterns. | ||
| */ | ||
| application: Name | ||
| application: Names |
| * It also accepts wildcards (`*`). | ||
| */ | ||
| snapshot: Name | ||
| snapshot: Names |
| * If the text does not have a header row, columns are named "column1", "column2", "column3", for example. | ||
| */ | ||
| column_names?: string | ||
| column_names?: Names |
| * If the text does not have a header row, columns are named "column1", "column2", "column3", for example. | ||
| */ | ||
| column_names?: string | ||
| column_names?: Names |
There was a problem hiding this comment.
Should this be string | string[] instead?
There was a problem hiding this comment.
Probably yes. The Name/Names is kinda arbitrary, so string will do since Names does not provide a benefit here.
I'll double check later.
| * If the text does not have a header role, columns are named "column1", "column2", "column3", for example. | ||
| */ | ||
| column_names?: string | ||
| column_names?: Names |
There was a problem hiding this comment.
Same comments as above, the underlying parsing function is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.