Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix the install-service.ps1 file name for windows #12312

Closed
wants to merge 5 commits into from

Conversation

wonseop
Copy link
Contributor

@wonseop wonseop commented Dec 29, 2023

Motivation/summary

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document. The file name of the apm-server installation document for Windows has been corrected.

Checklist

  • Documentation has been updated

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
The file name of the apm-server installation document for Windows has been corrected.
@wonseop wonseop requested a review from a team as a code owner December 29, 2023 13:34
Copy link
Contributor

mergify bot commented Dec 29, 2023

This pull request does not have a backport label. Could you fix it @wonseop? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 29, 2023
@carsonip carsonip added backport-8.12 Automated backport with mergify backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 3, 2024
@carsonip
Copy link
Member

carsonip commented Jan 3, 2024

Thank you!

@carsonip carsonip enabled auto-merge (squash) January 3, 2024 11:11
@carsonip carsonip disabled auto-merge January 3, 2024 13:33
@carsonip
Copy link
Member

carsonip commented Jan 3, 2024

Hi @wonseop , all commits are required to be signed. In the PR, the commit by @refarde is not signed. Is it possible for you / @refarde to get it signed in order to merge the PR? Thanks

@wonseop wonseop closed this Jan 3, 2024
@wonseop
Copy link
Contributor Author

wonseop commented Jan 3, 2024

I am so sorry. I accidentally closed the PR while operating it with my cell phone. It may be inconvenient, but please understand that I will reopen PR.

@wonseop wonseop reopened this Jan 3, 2024
@wonseop
Copy link
Contributor Author

wonseop commented Jan 3, 2024

Hi @wonseop , all commits are required to be signed. In the PR, the commit by @refarde is not signed. Is it possible for you / @refarde to get it signed in order to merge the PR? Thanks

@refarde is my sub-account. Now I don't know how to sign that commit. If you wish, I will remove the PR and create a new PR so that all commits can be verified.

@carsonip
Copy link
Member

carsonip commented Jan 3, 2024

@wonseop Feel free to create a new PR with signed commits. Thanks for going through the trouble.

@wonseop
Copy link
Contributor Author

wonseop commented Jan 4, 2024

I'll close this PR and open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants