Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python wheel: initial setup #257

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Python wheel: initial setup #257

wants to merge 10 commits into from

Conversation

tmi
Copy link

@tmi tmi commented Feb 6, 2025

No description provided.

@FussyDuck
Copy link

FussyDuck commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@tmi tmi force-pushed the project/wheelify branch from f6b246a to 5dd9152 Compare February 6, 2025 09:06
Copy link

github-actions bot commented Feb 6, 2025

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13176332396.

@tmi tmi force-pushed the project/wheelify branch from 5dd9152 to 6478a1b Compare February 6, 2025 10:53
Copy link

github-actions bot commented Feb 6, 2025

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13177800021.

Copy link

github-actions bot commented Feb 6, 2025

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13178107800.

@tmi tmi force-pushed the project/wheelify branch from e447f15 to 34d63e7 Compare February 10, 2025 14:19
@tmi tmi marked this pull request as ready for review February 10, 2025 14:19
@iainrussell
Copy link
Member

@wdeconinck, this is part of our effort to provide a large portion of our software stack as Python wheels. We have a new convention, where the binary libraries are stored on PyPi as lib, e.g. eccodeslib, mirlib, fdblib, up to multio. We would add atlaslib to this, so that mirlib can be built with atlas support. It's still a bit experimental, but we hope that earthkit-regrid can soon start benefiting from it. I'm happy to merge this in so that we can start using the GitHub actions to deploy it, if you give us the thumbs-up!

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13245038952.

1 similar comment
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13245038952.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13247690267.

2 similar comments
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13247690267.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13247690267.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13283002144.

2 similar comments
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13283002144.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13283002144.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13283430073.

1 similar comment
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13283430073.

@tmi
Copy link
Author

tmi commented Feb 13, 2025

There's one particular problem here: https://pypi.org/project/atlaslib/ is already taken by someone, so we need a different name here. No preference on my side, so something like "ecatlaslib"? Ftr atlas is also taken since Dec 2024 :/

This unfortunately means that findlibs invocation would have to be done via findlibs.find("atlas", <the new name>) instead of just findlibs.find("atlas")

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13368312983.

1 similar comment
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13368312983.

@wdeconinck
Copy link
Member

Hi, the new name could be something similar to what we have used for readthedocs.
There it is "atlas-ecmwf.readthedocs.io"
So this could be "atlaslib-ecmwf" ?

@tmi tmi force-pushed the project/wheelify branch from f07b385 to 7fc05bb Compare February 18, 2025 10:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (cea0222) to head (7fc05bb).
Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
- Coverage    79.88%   79.86%   -0.02%     
===========================================
  Files          836      836              
  Lines        65698    65734      +36     
===========================================
+ Hits         52480    52501      +21     
- Misses       13218    13233      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13389406108.

1 similar comment
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13389406108.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13550353798.

@wdeconinck
Copy link
Member

Hi @tmi could you please move this directory into ".github/python_wrapper_wheel" or so?
It should not be confused with the existence of an atlas Python API at this point.

@tmi
Copy link
Author

tmi commented Feb 28, 2025

@wdeconinck the convention we've started in all other ecmwf projects is to have the wrapper in python_wrapper and the python API (as in, proper interfaces callable from python, with python objects) in python_interface directory. See eg https://github.com/ecmwf/metkit/pull/55/files. That can of course be changed, ideally consistently across all the repositories -- python_wrapper is now in about 10... However I'm not sure why you would put it to .github, it does not have anything to do with github, does it? Or is it more about just hidding the directory somehow?

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13586782012.

1 similar comment
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13586782012.

@tmi tmi force-pushed the project/wheelify branch 2 times, most recently from 0ec4562 to 628da42 Compare February 28, 2025 16:01
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13592394913.

2 similar comments
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13592394913.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13592394913.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13592950577.

1 similar comment
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13592950577.

@tmi tmi force-pushed the project/wheelify branch from 355988a to 83773b8 Compare March 3, 2025 12:51
@tmi tmi force-pushed the project/wheelify branch from 83773b8 to 2b4fbfb Compare March 3, 2025 14:41
@tmi tmi force-pushed the project/wheelify branch from 2b4fbfb to f9d6ea1 Compare March 3, 2025 14:43
@tmi
Copy link
Author

tmi commented Mar 3, 2025

@wdeconinck what do you think now? The paths have been updated -- is it mergeable now?

Copy link

github-actions bot commented Mar 3, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13634278064.

2 similar comments
Copy link

github-actions bot commented Mar 3, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13634278064.

Copy link

github-actions bot commented Mar 3, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13634278064.

Copy link

github-actions bot commented Mar 3, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13635221288.

1 similar comment
Copy link

github-actions bot commented Mar 3, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13635221288.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants