Python Wrapper: add Atlas #27
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27 +/- ##
========================================
Coverage 53.92% 53.92%
========================================
Files 612 612
Lines 25864 25864
Branches 2271 2271
========================================
Hits 13947 13947
Misses 11917 11917 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmi
force-pushed
the
pyWrap/addAtlasDep
branch
2 times, most recently
from
6c23e3e to
9ed8ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the python wrapper wheel with Mir depend on and utilize Atlas
This depends on ecmwf/atlas#257 being merged, and additionally I'll need to put there the atlas stripping. I've already tested locally and it seems not to cause any problem in this case.
Also, I believe TESSELATION was asked for in the Atlas build -- that includes me building and bundling Qhull external library into atlas, that will also take some time.
FYI @pmaciel @iainrussell