Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of new Image(device, width, height) #2869

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Replace usages of new Image(device, width, height) #2869

merged 2 commits into from
Apr 9, 2025

Conversation

ShahzaibIbrahim
Copy link
Contributor

Replacing it with imageGcDrawer

@ShahzaibIbrahim ShahzaibIbrahim mentioned this pull request Mar 28, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 32m 10s ⏱️ - 5m 50s
 7 918 tests ±0   7 689 ✅  - 1  228 💤 ±0  1 ❌ +1 
23 841 runs  ±0  23 092 ✅  - 1  748 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 1333a4e. ± Comparison against base commit 0018006.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 313615d11dda5ce782b0eb35b8a22657d4e66413 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 1 Apr 2025 12:09:00 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
index b6e6c4e55d..9e193a6310 100644
--- a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.css.swt;singleton:=true
-Bundle-Version: 0.15.500.qualifier
+Bundle-Version: 0.15.600.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
index 9a63a5630f..5e46a06a14 100644
--- a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
-Bundle-Version: 3.19.100.qualifier
+Bundle-Version: 3.19.200.qualifier
 Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@ShahzaibIbrahim ShahzaibIbrahim linked an issue Apr 2, 2025 that may be closed by this pull request
Replace usages of new Image(device, width, height) / new GC(image) vi-eclipse/Eclipse-Platform#188
Open
@HannesWell HannesWell mentioned this pull request Apr 2, 2025
Draft
fedejeanne
fedejeanne previously requested changes Apr 9, 2025
View reviewed changes
bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/FormImages.java
Comment on lines 128 to 130
GC gc = new GC(image);
gc.setBackground(color1);
gc.fillRectangle(0, 0, 1, fLength);
gc.setForeground(color2);
gc.setBackground(color1);
gc.fillGradientRectangle(0, fMarginHeight + 2, 1, fTheight - 2, true);

gc.dispose();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really still need to create the GC and dispose it right away?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put a pin on it

@fedejeanne fedejeanne mentioned this pull request Apr 9, 2025
Open
@fedejeanne
Copy link
Contributor

Test failure on Mac is unrelated: #294

@fedejeanne fedejeanne merged commit 2e549bb into eclipse-platform:master Apr 9, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedejeanne fedejeanne fedejeanne approved these changes

@HannesWell HannesWell HannesWell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace usages of new Image(device, width, height) / new GC(image)
4 participants
@ShahzaibIbrahim @eclipse-platform-bot @fedejeanne @HannesWell