-
Notifications
You must be signed in to change notification settings - Fork 0
Replace usages of new Image(device, width, height) / new GC(image) #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usages of new Image(device, width, height) / new GC(image) #188
Comments
Can you please check whether this is a reasonable task, @akoch-yatta? |
Attaching file to categorize the usages in order to separately deal with the changes. First priority being replacing in Platform/SWT |
@ShahzaibIbrahim please address this comment too: eclipse-platform/eclipse.platform.ui#2869 (comment) Keep in mind that |
As documented in #171, images instantiated with a fixed width/height, which are usually used as a canvas to manually draw an, are insufficient for multi-zoom scenarios, in which an image to be drawn on demand may be required in different sizes.
In #143, a new constructor for Image, taking an
ImageGcDrawer
, has been introduced to replace the implementation in above mentioned use cases with a dynamic generation of an image at the propert size.This is a follow-up task consisting of the following steps:
new Image(device, width, height)
with a subsequent call tonew GC(image)
with a properImageGcDrawer
The text was updated successfully, but these errors were encountered: