Ensure sendMeasureItemEvent is only called for OS.TTN_SHOW or custom tooltips #2324
+17
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjose696
force-pushed
the
arunjose696/360/scrollbars_temp_fix
branch
from
943caec to
abec851
Compare
amartya4256
force-pushed
the
arunjose696/360/scrollbars_temp_fix
branch
2 times, most recently
from
e399177 to
d0d48ce
Compare
tooltips Prior to PR eclipse-platform#2241, sendMeasureItemEvent was only invoked when the tooltip was not a CustomTooltip. However, after that change, sendMeasureItemEvent is now called for all tooltips. This results in an unintended side effect: sendMeasureItemEvent compares the item's width(obtained from TableItem.getBounds()) to the width of column (via OS.LVM_GETCOLUMNWIDTH) it is present in and sometimes concludes incorrectly that the item doesn't fit. This causes an unnecessary scrollbar to appear, even though the item is fully contained within the column. While the root cause lies in how column item width is calculated (which should be addressed separately), this change acts as a temporary fix to prevent scrollbars from appearing erroneously particularly in the MultipleHyperlinkPresenter. This workaround aligns with the original behavior prior to PR eclipse-platform#2241 as sendMeasureItemEvent would not be called for non customToolTip and restores expected UI behavior for now.
amartya4256
force-pushed
the
arunjose696/360/scrollbars_temp_fix
branch
from
d0d48ce to
ca8bfa0
Compare
|
To simplify this, SendMeasureItemEvent should only be called in 2 cases:
Hence, the condition in which it must not be called on a WM_NOTIFY message is when isCustomTooltip() is false and the message is a TTN_GETDISPINFO as calling this method can modify the tooltip in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to PR #2241,
Table.sendMeasureItemEventwas only invoked when the tooltip was not a CustomTooltip. However, after that change,sendMeasureItemEvent()is now called for all tooltips.This results in an unintended side effect:
sendMeasureItemEvent()compares the item's width(obtained fromTableItem.getBounds()) to the width of column it is present in (obtained fromOS.LVM_GETCOLUMNWIDTH) and sometimes concludes incorrectly that the item doesn't fit. This causes an unnecessary scrollbar to appear, even though the item is fully contained within the column.While the root cause is possibly in how column item width is calculated (which should be addressed separately), this change acts as a fix to prevent scrollbars from appearing erroneously.
This workaround aligns with the original behavior prior to PR #2241 as sendMeasureItemEvent would not be called for non customToolTip and restores expected UI behavior for now.
Steps to reproduce
See the steps in vi-eclipse/Eclipse-Platform#360