#25 language pack crashes#91
Merged
Merged
Conversation
Insert menus by (localised) string and fall back to default positions if that fails.
rsjbailey
force-pushed
the
ial_language_pack_crashes
branch
3 times, most recently
from
6ec2c89 to
d3a0e7c
Compare
Default position checking and string localisation now perfomed by menu classes to simplify use.
rsjbailey
force-pushed
the
ial_language_pack_crashes
branch
from
d3a0e7c to
af4aa4e
Compare
firthm01
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #65
fixes #25
As #65 but with refactor to reduce the amount of windows specific code