#25 language pack crashes

[merktj]

As suggested by @firthm01 to fix #25, the extension first trys to insert the menus by searching for the corresponding labels. If this fails it will fall back to the hard-coded fallback positions.

After sucessfully inserting the menus by using the labels, the fallback positions are checked for correctness. However, this could also fail if other extensions are manipulating the reaper menus. So instead of causing an exception, a warning will be displayed if this check fails.

[firthm01]

Thanks - tested, working.

However, if we could request a minor change; after discussing with Rich, we think that assertions would probably be more appropriate than message boxes after all (i.e, just assert(reaperMainMenu->checkHardcodedPosition("Text"))). The reason being that the only people that would encounter the message boxes are people who are not affected by the issue (since the text must have been successfully found to check the hardcoded indexes) so it's just going to be an inconvenience to those users since it will occur on every start up.
Hopefully with an assert, a dev should be alerted to it and can address the problem.

[merktj]

The reason why I chose a warning is interference with other REAPER extensions. If these add menus too, an assertion would prohibit compatibility, while a warning on every startup could at least be acceptable. But in this case both of course is not optimal.

Edit: Since assertions only show up in Debug build, compatibility with other extensions is still ensured. Hence, I changed the warnings to assertions.

[rsjbailey]

replaced by #91