-
Notifications
You must be signed in to change notification settings - Fork 872
[23881] Avoid casting GUID_t into InstanceHandle_t
#6148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <[email protected]>
GUID_t into InstanceHandle_t
richiware
approved these changes
Nov 5, 2025
11 tasks
Contributor
🧪 CI InsightsHere's what we observed from your CI run for c1c433a. ❌ Job Failures
|
Member
Author
|
@Mergifyio backport 3.3.x 3.2.x 2.14.x |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 699c88d)
13 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 699c88d)
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 699c88d)
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During my investigation of the failing tests in #6070, I discovered we are wrongly casting a
GUID_tinto anInstanceHandle_t.This PR fixes it in an ABI-compatible way by adding a new field to
DomainParticipantImpl.For 3.5.0, I will open another PR changing the API to return the
InstanceHandle_tby value.@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist