Skip to content

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 5, 2025

Description

During my investigation of the failing tests in #6070, I discovered we are wrongly casting a GUID_t into an InstanceHandle_t.

This PR fixes it in an ABI-compatible way by adding a new field to DomainParticipantImpl.

For 3.5.0, I will open another PR changing the API to return the InstanceHandle_t by value.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.4.1 milestone Nov 5, 2025
@MiguelCompany MiguelCompany changed the title [23881] Avoid casting GUID_t into InstanceHandle_t [23881] Avoid casting GUID_t into InstanceHandle_t Nov 5, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima November 5, 2025 09:25
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 5, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2025

🧪 CI Insights

Here's what we observed from your CI run for c1c433a.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@MiguelCompany MiguelCompany merged commit 699c88d into master Nov 5, 2025
25 of 28 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/23880 branch November 5, 2025 17:44
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 3.3.x 3.2.x 2.14.x

@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2025

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 5, 2025
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 699c88d)
mergify bot pushed a commit that referenced this pull request Nov 5, 2025
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 699c88d)
mergify bot pushed a commit that referenced this pull request Nov 5, 2025
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 699c88d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants