Skip to content

[23750] Upgrade to macOS Sequoia #6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+12 −13
Open

[23750] Upgrade to macOS Sequoia #6070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e6fdf5
Refs #23750. Change runner in CI.
MiguelCompany Oct 1, 2025
fee6611
Refs #23750. Update platform support.
MiguelCompany Oct 1, 2025
a018d00
Refs #23750. Apply suggestion.
MiguelCompany Oct 10, 2025
0b4bb8a
Refs #23750. Update to macos-15.
MiguelCompany Oct 14, 2025
c6cfe31
Refs #23750. Do not build IPv6 blackbox tests in Mac.
MiguelCompany Oct 15, 2025
4765e44
Refs #23750. Exclude whitelist tests.
MiguelCompany Oct 21, 2025
9a5fafd
Refs #23750. Fix DataWriterTests.
MiguelCompany Nov 5, 2025
081571d
Refs #23750. Change blacklisting of IPv6 test.
MiguelCompany Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/reusable-mac-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,16 @@ on:
type: boolean
default: true

env:
test_blocklist: 'InterfaceWhitelist|send_to_allowed_interface|v6'

defaults:
run:
shell: bash

jobs:
fastdds_build:
# As explained in https://github.com/actions/runner-images/tree/main?tab=readme-ov-file#available-images,
# *-latest images are not always the latest available versions. The minimum version of the macOS image
# with clang 15 is macos-13 (see
# https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#language-and-runtime),
# so we'll use that one for now, as clang 15 is the supported compiler for Fast DDS in macOS.
# (see https://github.com/eProsima/Fast-DDS/blob/master/PLATFORM_SUPPORT.md#compilers)
runs-on: macos-13
runs-on: macos-15-intel
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -153,7 +150,7 @@ jobs:
fastdds_test:
needs: fastdds_build
name: fastdds_test (${{ matrix.cmake_build_type }})
runs-on: macos-13
runs-on: macos-15-intel
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -225,7 +222,9 @@ jobs:
colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_test.meta
colcon_test_args: ${{ inputs.colcon-args }}
colcon_test_args_default: --event-handlers=console_direct+
ctest_args: ${{ inputs.ctest-args }}
ctest_args: >
${{ inputs.ctest-args }}
${{ format('-E "{0}"', env.test_blocklist) }}
packages_names: fastdds
workspace: ${{ github.workspace }}
test_report_artifact: ${{ format('test_report_{0}_{1}_{2}', inputs.label, github.job, join(matrix.*, '_')) }}
Expand Down
4 changes: 2 additions & 2 deletions PLATFORM_SUPPORT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Community members may provide assistance with these platforms.

## Platforms

|Architecture|Ubuntu Noble (24.04)|Ubuntu Jammy (22.04)|MacOS Ventura (13)|Windows 10 (VS2019)|Windows 11 (VS2022)|Debian Buster (10)|Android 12 |Android 13 | QNX 7.1 |
|Architecture|Ubuntu Noble (24.04)|Ubuntu Jammy (22.04)|MacOS Sequoia (15)|Windows 10 (VS2019)|Windows 11 (VS2022)|Debian Buster (10)|Android 12 |Android 13 | QNX 7.1 |
|------------|--------------------|--------------------|------------------|-------------------|-------------------|------------------|-----------|-----------|-----------|
|amd64 |Tier 3 [^a][^s] |Tier 1 [^a][^s] |Tier 1 [^s] |Tier 1 [^a][^s] |Tier 1 [^a][^s] |Tier 3 [^s] |Tier 3 [^s]|Tier 3 [^s]|Tier 3 [^s]|
|amd32 | | | |Tier 3 [^a][^s] |Tier 3 [^a][^s] | | | | |
Expand All @@ -48,7 +48,7 @@ More information about Platforms support and eProsima products compatibility can
Tier 1 compilers and minimum supported versions:

* GCC 11.4 [^d]
* Clang 15
* Clang 16
* MSVC v142 (Visual Studio 2019)

[^d]: Using GCC's Thread Sanitizer flags in conjunction with GCC 11 to analyze Fast DDS threaded behavior produces
Expand Down
4 changes: 2 additions & 2 deletions test/unittest/dds/publisher/DataWriterTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ TEST(DataWriterTests, Write)
data.message("HelloWorld");
ASSERT_FALSE(datawriter->write(nullptr, HANDLE_NIL) == RETCODE_OK);
ASSERT_TRUE(datawriter->write(&data, HANDLE_NIL) == RETCODE_OK);
ASSERT_TRUE(datawriter->write(&data, participant->get_instance_handle()) ==
ASSERT_TRUE(datawriter->write(&data, datawriter->get_instance_handle()) ==
RETCODE_PRECONDITION_NOT_MET);

ASSERT_TRUE(publisher->delete_datawriter(datawriter) == RETCODE_OK);
Expand Down Expand Up @@ -825,7 +825,7 @@ TEST(DataWriterTests, WriteWithTimestamp)
datawriter->write_w_timestamp(&data, HANDLE_NIL, fastdds::dds::c_TimeInvalid));
// 3. Calling write with a wrong instance handle returns RETCODE_PRECONDITION_NOT_MET
ASSERT_EQ(RETCODE_PRECONDITION_NOT_MET,
datawriter->write_w_timestamp(&data, participant->get_instance_handle(), ts));
datawriter->write_w_timestamp(&data, datawriter->get_instance_handle(), ts));
// 4. Correct case
ASSERT_EQ(RETCODE_OK, datawriter->write_w_timestamp(&data, HANDLE_NIL, ts));

Expand Down
Loading