[22894] Apply demangling to ROS 2 topics in IDL view #266
+253
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
juanjo4936
requested review from
richiprosima
and removed request for
richiprosima
Signed-off-by: Juanjo Garcia <[email protected]>
juanjo4936
requested review from
richiprosima
and removed request for
richiprosima
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
juanjo4936
requested review from
richiprosima
and removed request for
richiprosima
Signed-off-by: Juanjo Garcia <[email protected]>
…mangling Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
…retrieve the information Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: Juanjo Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the code to process the IDL files generated from the TypeObject, eliminating the ROS 2 mangling in case it is necessary, before registering the IDL. If it was demangled, the original one is saved in a second map, so it can still be retrieved. A third map registers the relation between the original name and the demangled one, for the monitor to use. This PR also includes the functions needed for the monitor to be able to access this information.