Skip to content

Conversation

@clalancette
Copy link
Contributor

@clalancette clalancette commented Nov 10, 2025

Description

The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies.

I've opened this against the 2.3.x branch (since that is what ROS 2 is currently using), but it probably should be backported to all branches.

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

The dependencies on ament_cmake, ament_cmake_gtest, and
googletest-distribution are only needed when building
for tests, so we should only inject them as test dependencies.

Signed-off-by: Chris Lalancette <[email protected]>
@MiguelCompany MiguelCompany changed the base branch from 2.3.x to master November 12, 2025 13:26
@MiguelCompany MiguelCompany added this to the v2.3.5 milestone Nov 12, 2025
@MiguelCompany MiguelCompany requested review from richiware and removed request for richiware November 12, 2025 13:26
@MiguelCompany MiguelCompany merged commit 88eb2ab into eProsima:master Nov 14, 2025
8 checks passed
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.2.x 1.0.x

@mergify
Copy link

mergify bot commented Nov 14, 2025

backport 2.2.x 1.0.x

✅ Backports have been created

Details

@MiguelCompany
Copy link
Member

@clalancette Thank you!

mergify bot pushed a commit that referenced this pull request Nov 14, 2025
The dependencies on ament_cmake, ament_cmake_gtest, and
googletest-distribution are only needed when building
for tests, so we should only inject them as test dependencies.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 88eb2ab)

# Conflicts:
#	colcon.pkg
mergify bot pushed a commit that referenced this pull request Nov 14, 2025
The dependencies on ament_cmake, ament_cmake_gtest, and
googletest-distribution are only needed when building
for tests, so we should only inject them as test dependencies.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 88eb2ab)
@clalancette
Copy link
Contributor Author

@clalancette Thank you!

Thanks for reviewing and merging :).

MiguelCompany added a commit that referenced this pull request Dec 10, 2025
* Change colcon.pkg dependencies to be test-dependencies (#293)

The dependencies on ament_cmake, ament_cmake_gtest, and
googletest-distribution are only needed when building
for tests, so we should only inject them as test dependencies.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 88eb2ab)

# Conflicts:
#	colcon.pkg

* Fix conflicts

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Dec 12, 2025
The dependencies on ament_cmake, ament_cmake_gtest, and
googletest-distribution are only needed when building
for tests, so we should only inject them as test dependencies.


(cherry picked from commit 88eb2ab)

Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants