-
Notifications
You must be signed in to change notification settings - Fork 123
Change colcon.pkg dependencies to be test-dependencies. #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MiguelCompany
merged 1 commit into
eProsima:master
from
clalancette:clalancette/fix-colcon-pkg
Nov 14, 2025
Merged
Change colcon.pkg dependencies to be test-dependencies. #293
MiguelCompany
merged 1 commit into
eProsima:master
from
clalancette:clalancette/fix-colcon-pkg
Nov 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies. Signed-off-by: Chris Lalancette <[email protected]>
MiguelCompany
approved these changes
Nov 12, 2025
Member
|
@Mergifyio backport 2.2.x 1.0.x |
✅ Backports have been createdDetails
|
Member
|
@clalancette Thank you! |
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 88eb2ab) # Conflicts: # colcon.pkg
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 88eb2ab)
This was referenced Nov 14, 2025
Contributor
Author
Thanks for reviewing and merging :). |
MiguelCompany
added a commit
that referenced
this pull request
Dec 10, 2025
* Change colcon.pkg dependencies to be test-dependencies (#293) The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 88eb2ab) # Conflicts: # colcon.pkg * Fix conflicts Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Miguel Company <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Dec 12, 2025
The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies. (cherry picked from commit 88eb2ab) Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dependencies on ament_cmake, ament_cmake_gtest, and googletest-distribution are only needed when building for tests, so we should only inject them as test dependencies.
I've opened this against the 2.3.x branch (since that is what ROS 2 is currently using), but it probably should be backported to all branches.
@Mergifyio backport 2.2.x 1.0.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist