Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): replaced column-type of "row-header" with boolean row-header #2355

Closed
wants to merge 59 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
eff242b
feat(table): replaced column-type of row-header with boolean row-header
WinkeeFace Dec 24, 2024
6a0c92b
feat(table): replaced column-type of row-header with boolean row-header
WinkeeFace Dec 24, 2024
b767d14
feat(table): update row-header attribute to boolean format in examples
WinkeeFace Jan 2, 2025
21f9d1b
feat(table): update TableHeader interface and examples to use WithNor…
WinkeeFace Jan 2, 2025
9db2bde
fix(ebay-textbox): update input interface to include textarea-specifi…
WinkeeFace Jan 9, 2025
fe70bc2
fix(table): update examples to use 'as const' for numeric column-type
WinkeeFace Jan 9, 2025
6217423
fix(table): update examples to use 'as const' for column-type attributes
WinkeeFace Jan 9, 2025
de35355
Merge branch '2313-ebay-table-various-fixes' of https://github.com/eB…
WinkeeFace Jan 9, 2025
a9fb26f
fix(table): update examples to use 'as const' for numeric column-type…
WinkeeFace Jan 10, 2025
4214645
fix(table): remove 'as const' from numeric column-type headers in exa…
WinkeeFace Jan 13, 2025
b4b9899
chore: upgrade marko & mtc, fix type errors (#2376)
LuLaValva Jan 15, 2025
674712a
fix(ebay-combobox): floating label type (#2370)
MaiDeveloper Jan 15, 2025
f3513e6
feat(ebay-area-chart): refactor existing area chart to design specs (…
mikehobi Jan 15, 2025
14618f8
chore: fixed mtc test
agliga Jan 15, 2025
94d2cc6
feat(table): replaced column-type of row-header with boolean row-header
WinkeeFace Dec 24, 2024
3ce6af1
feat(table): update row-header attribute to boolean format in examples
WinkeeFace Jan 2, 2025
bf3d1b6
feat(table): update TableHeader interface and examples to use WithNor…
WinkeeFace Jan 2, 2025
c4d32e4
fix(table): update examples to use 'as const' for column-type attributes
WinkeeFace Jan 9, 2025
749e6be
fix(table): update examples to use 'as const' for numeric column-type
WinkeeFace Jan 9, 2025
d8717a3
fix(table): update examples to use 'as const' for numeric column-type…
WinkeeFace Jan 10, 2025
0f160f5
fix(table): remove 'as const' from numeric column-type headers in exa…
WinkeeFace Jan 13, 2025
f2a5ffa
Merge branch '2313-ebay-table-various-fixes' of https://github.com/eB…
WinkeeFace Jan 16, 2025
162ee30
fix(ebay-table): remove aria-pressed attribute for improved accessibi…
WinkeeFace Jan 16, 2025
437ad6b
chore: remove .DS_Store files and update .gitignore
WinkeeFace Jan 16, 2025
df32cbb
chore: updated actions/upload-pages-artifact to v4
agliga Jan 16, 2025
40a75b3
feat(table): replaced column-type of row-header with boolean row-header
WinkeeFace Dec 24, 2024
b5b8cb9
feat(table): update TableHeader interface and examples to use WithNor…
WinkeeFace Jan 2, 2025
7c1a0f2
fix(table): update examples to use 'as const' for column-type attributes
WinkeeFace Jan 9, 2025
64c0ed2
fix(table): update examples to use 'as const' for numeric column-type
WinkeeFace Jan 9, 2025
4d8b309
fix(table): update examples to use 'as const' for numeric column-type…
WinkeeFace Jan 10, 2025
d8dc4e7
fix(table): remove 'as const' from numeric column-type headers in exa…
WinkeeFace Jan 13, 2025
1a21059
fix(ebay-table): remove aria-pressed attribute for improved accessibi…
WinkeeFace Jan 16, 2025
1922b18
chore: remove .DS_Store files and update .gitignore
WinkeeFace Jan 16, 2025
e61cc5b
Merge branch '2313-ebay-table-various-fixes' of https://github.com/eB…
WinkeeFace Jan 16, 2025
a22c786
feat(table): replaced column-type of row-header with boolean row-header
WinkeeFace Dec 24, 2024
53ea80b
feat(table): update row-header attribute to boolean format in examples
WinkeeFace Jan 2, 2025
d4a3cf0
feat(table): update TableHeader interface and examples to use WithNor…
WinkeeFace Jan 2, 2025
2e294b6
fix(table): update examples to use 'as const' for column-type attributes
WinkeeFace Jan 9, 2025
30c11f1
fix(table): update examples to use 'as const' for numeric column-type
WinkeeFace Jan 9, 2025
59384f0
fix(table): update examples to use 'as const' for numeric column-type…
WinkeeFace Jan 10, 2025
94a8f63
fix(table): remove 'as const' from numeric column-type headers in exa…
WinkeeFace Jan 13, 2025
8a444aa
feat(table): replaced column-type of row-header with boolean row-header
WinkeeFace Dec 24, 2024
9228883
feat(table): update TableHeader interface and examples to use WithNor…
WinkeeFace Jan 2, 2025
22afa04
fix(table): update examples to use 'as const' for column-type attributes
WinkeeFace Jan 9, 2025
969cddc
fix(table): update examples to use 'as const' for numeric column-type
WinkeeFace Jan 9, 2025
4dfc7ee
fix(table): update examples to use 'as const' for numeric column-type…
WinkeeFace Jan 10, 2025
a35cff5
fix(table): remove 'as const' from numeric column-type headers in exa…
WinkeeFace Jan 13, 2025
a9baea8
fix(ebay-table): remove aria-pressed attribute for improved accessibi…
WinkeeFace Jan 16, 2025
87eb0c4
chore: remove .DS_Store files and update .gitignore
WinkeeFace Jan 16, 2025
c191c27
feat(table): update TableHeader interface and examples to use WithNor…
WinkeeFace Jan 2, 2025
af5d418
fix(table): update examples to use 'as const' for column-type attributes
WinkeeFace Jan 9, 2025
21c226f
fix(table): update examples to use 'as const' for numeric column-type
WinkeeFace Jan 9, 2025
2a23d76
fix(table): update examples to use 'as const' for numeric column-type…
WinkeeFace Jan 10, 2025
d21ce14
fix(table): remove 'as const' from numeric column-type headers in exa…
WinkeeFace Jan 13, 2025
1406f7f
Merge branch '2313-ebay-table-various-fixes' of https://github.com/eB…
WinkeeFace Jan 16, 2025
c59c030
fix(table): remove 'row-header' attribute from table header snapshots
WinkeeFace Jan 16, 2025
45a0351
parent df32cbbad749cd3a0cd27802c9409b27d5e599f5
WinkeeFace Dec 24, 2024
3183edd
fix(table): remove 'row-header' attribute from table header snapshots
WinkeeFace Jan 16, 2025
59159b6
Merge branch '2313-ebay-table-various-fixes' of https://github.com/eB…
WinkeeFace Jan 16, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Binary file not shown.
5 changes: 5 additions & 0 deletions .changeset/sharp-bees-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": patch
---

TS fix for combobox
5 changes: 5 additions & 0 deletions .changeset/sixty-experts-marry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": minor
---

Add area chart
5 changes: 5 additions & 0 deletions .changeset/slimy-items-change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": patch
---

fix(table): replaced column-type of "row-header" with boolean row-header
5 changes: 5 additions & 0 deletions .changeset/thirty-walls-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": patch
---

Upgrade dependencies
5 changes: 5 additions & 0 deletions .changeset/wet-wombats-roll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": patch
---

Updated the component-browser.ts file to reference shared attributes from tags-html.d.ts and added the Textbox class implementation.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: coverage/lcov.info
- name: Upload artifact
uses: actions/upload-pages-artifact@v1
uses: actions/upload-pages-artifact@v3

# Deployment job
deploy:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ yarn.lock
.env
_cdn
__screenshots__
.DS_Store
204 changes: 95 additions & 109 deletions package-lock.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@
"@commitlint/config-conventional": "^19",
"@ebay/browserslist-config": "^2.10.0",
"@ebay/skin": "~18.6.0",
"@marko/compiler": "^5.37.23",
"@marko/compiler": "^5.39.10",
"@marko/prettyprint": "^3.0.1",
"@marko/testing-library": "^6",
"@marko/type-check": "^1.2.4",
"@marko/type-check": "^1.3.12",
"@marko/vite": "^4.1.20",
"@storybook/addon-a11y": "^8.3.6",
"@storybook/addon-docs": "^8.3.6",
Expand Down Expand Up @@ -132,7 +132,7 @@
"libphonenumber-js": "^1.11.17",
"lint-staged": "^15.2.11",
"lintspaces-cli": "^1.0.0",
"marko": "^5.35.32",
"marko": "^5.37.10",
"playwright": "^1.49.1",
"postcss-less": "^6.0.0",
"prettier": "^3.4.2",
Expand Down
26 changes: 24 additions & 2 deletions src/common/charts/shared.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
export const chartFontFamily = '"Market Sans", Arial, sans-serif',
backgroundColor = "var(--color-background-primary)",
gridColor = "var(--color-data-viz-grid)",
labelsColor = "var(--color-data-viz-labels)",
legendColor = "var(--color-data-viz-legend)",
labelsColor = "var(--color-foreground-secondary)",
legendColor = "var(--color-foreground-primary)",
legendInactiveColor = "var(--color-data-viz-legend-inactive)",
legendHoverColor = "var(--color-data-viz-legend-hover)",
tooltipBackgroundColor = "var(--color-background-primary)",
Expand Down Expand Up @@ -79,6 +79,7 @@ export const chartFontFamily = '"Market Sans", Arial, sans-serif',
const color = strokeColorMapping[i % strokeColorMapping.length];
series[i].lineColor = color;
series[i].borderColor = color;
series[i].fillOpacity = 1;
}
},
setDonutColors = function (series: any) {
Expand Down Expand Up @@ -110,4 +111,25 @@ export const chartFontFamily = '"Market Sans", Arial, sans-serif',
});

return colors.map((color: any) => color.lineColor);
},
setSeriesMarkerStyles = function (series: Highcharts.PlotAreaOptions[]) {
series.forEach((s, i) => {
s.zIndex = series.length - i;
s.marker = {
symbol: "circle",
lineWidth: 1,
fillColor: "black",
lineColor: "white",
states: {
hover: {
animation: { duration: 0 },
radius: 4,
lineWidth: 2,
},
normal: {
animation: false,
},
},
};
});
};
6 changes: 6 additions & 0 deletions src/components/ebay-area-chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,9 @@
</h1>

The area chart displays one to five series of data points as an interactive stacked area chart

## Examples and Documentation

- [Storybook](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Storybook Docs](https://ebay.github.io/ebayui-core/?path=/docs/charts-ebay-area-chart)
- [Code Examples](https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-area-chart/examples)
143 changes: 0 additions & 143 deletions src/components/ebay-area-chart/area-chart.stories-ignore.ts

This file was deleted.

Loading
Loading