-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): replaced column-type of "row-header" with boolean row-header #2355
base: 15.0.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, thanks @WinkeeFace! Just a few notes:
- Those tests are failing because you didn't include
rowHeader
in theindex.marko
destructure here. - Since Marko 5 / eBayUI normalizes kebab-case to camelCase so both are accepted, that needs to be accommodated for in TypeScript. To do this, you can either add duplicate
"row-header"?: boolean;
and"column-type"?: ...
types in the interface (probably not recommended), or you can switch everything to kebab-case and useWithNormalizedProps<>
like we do forInput
(preferred). =true
is implied in Marko attributes (same as HTML), so there are a few examples that can be simplified (I showed one example in a code comment)
Thank you for the feedback! I'll make those corrections. |
|
Description
Replaced
column-type
ofrow-header
with a booleanrow-header
in theebay-table
component. Updated the relevant Marko and JSON files to reflect this change.Context
This change was made to simplify the handling of row headers and improve ARIA accessibility. The boolean
row-header
is more intuitive and aligns better with accessibility standards.References
Screenshots
N/A