Skip to content

Finalise first pass review #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Finalise first pass review #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68044f0
Adds comma for flow #22
iteles Sep 30, 2018
0748b0f
Updates gif in step 3 to match code #62
iteles Sep 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ edit the _initial value_ of the model
(_e.g: change the initial value from 0 to 9_).
Don't forget to save the file!

![elm-architecture-code-update](https://cloud.githubusercontent.com/assets/194400/25780662/adff6418-3323-11e7-8089-fae4bdc515e8.gif)
![elm-architecture-code-update](https://user-images.githubusercontent.com/4185328/46260332-6f107980-c4dc-11e8-98c8-e1775453dfac.gif)

### 4. Refresh the Web Browser

Expand Down Expand Up @@ -497,7 +497,7 @@ http://127.0.0.1:8000/examples/counter-basic-test/?coverage

![counter-coverage](https://cloud.githubusercontent.com/assets/194400/25816673/b994d25a-341c-11e7-8fd1-52e136fb7152.png)

Because all functions are "pure" testing
Because all functions are "pure", testing
the `update` function is _very_ easy:

```js
Expand Down