Skip to content

Finalise first pass review #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Finalise first pass review #66

merged 2 commits into from
Oct 2, 2018

Conversation

iteles
Copy link
Member

@iteles iteles commented Oct 2, 2018

Finalising my first pass at the main README this tutorial (#22) with the tiniest of adjustments for flow and swapping out the gif to close #62

@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         312    380   +68     
  Branches       89    114   +25     
=====================================
+ Hits          312    380   +68
Impacted Files Coverage Δ
examples/todo-list/elmish.js 100% <0%> (ø) ⬆️
examples/todo-list/todo-app.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad15df...0748b0f. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iteles thanks for updating and improving the grammar. 🎉

@nelsonic nelsonic merged commit b9de475 into master Oct 2, 2018
@nelsonic nelsonic deleted the review-todo branch October 2, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gif on line 169 of README needs updating
2 participants