Upgrade the Temporal Worker Controller to 1.12 - #1194
Merged
Merged
Conversation
Both charts 0.28.0 -> 0.31.0, controller 1.9.0 -> 1.12.0. 1.12 prunes superseded inactive versions, surfaces poller and gate-workflow health as conditions, and stops treating an already-current version as a rollback; 1.11 scales draining versions back up from zero. Chart 0.30.0 removed the cert-manager subchart. This platform never installed it (certmanager.install: false), so no migration is needed; the now-dead install key is dropped and the rendered manifests are identical. The webhook certificate is still issued by the platform's cert-manager through the chart's self-signed Issuer.
Collaborator
Author
Rollout drill on controller 1.12 (from #1196's pins)The real Progressive rollout ran on Kind with this branch's controller overlaid. The controller log:
Still to observe: pruning of the superseded versions. The spec has |
14 of 16 tasks
duynhne
added a commit
that referenced
this pull request
Oct 2, 2026
Both releases move to Temporal Go SDK 1.49.0 and passed the full local-stack release audit (A/B/C + C22) on their merged SHAs. The worker pins start a Progressive rollout through the Worker Controller, which is the rollout drill for #1194.
Collaborator
Author
Version pruning, observed on controller 1.12About an hour after promotion (
Afterwards:
That completes the drill: ramp 10 → 50 → current, drain, scale-down and prune all ran on 1.12. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This upgrades both Worker Controller charts from
0.28.0to0.31.0(controller1.9.0→1.12.0). The owner picked this from the SDK and server follow-ups in #1107.From the official notes (v1.10.0, v1.11.0, v1.12.0):
ClusterConnectionCRD.cert-manager: this platform always had
certmanager.install: false, so the upgrade guide's migration does not apply. I dropped the now-deadinstallkey. Our values render identically with and without it on 0.31.0. The webhook certificate (temporal-worker-controller-serving-cert→ Secretwebhook-server-cert, CA injected into the WorkerResourceTemplate webhook) is still issued by the platform's cert-manager.Render diff, 0.28.0 vs 0.31.0, with our values:
clusterconnectionsandclusterconnections/finalizers;WRT_HPA_MATCH_LABELS_STRIP_TEMPORAL_PREFIX=false;Verified on Kind (branch overlay)
crdsupgraded to 0.31.0 first (dependsOn), then the manager; imagetemporalio/temporal-worker-controller:v1.12.0order/order-fulfillment(current2.10.1-fcc8) andcheckout/checkout-abandon(current0.13.1-4955):ConnectionHealthy=True, Ready=True, RolloutComplete=TrueReady=True; both ScaledObjects Readymake e2e-saga GATE=kindDraft until the rollout drill runs. The G4 release (order and checkout on SDK 1.49) pins new worker builds on Kind. That gives a real Progressive rollout (10 → 50 → 100) on this controller, and lets me see the superseded version drain and get pruned. I'll add that evidence here before marking this ready.