Move payment reads under payments/ in docs - #1195
Merged
Merged
Conversation
payment-service v2.7.0 serves the two Backoffice reads that broke ADR-017 under the payments collection noun: /payment/v1/protected/payments/attempts?status=open /payment/v1/protected/payments/reconciliation/runs[/:id] docs/api lists the canonical paths and marks the old ones deprecated aliases; the k6 staff suite and e2e-audit A18/A22 call the new paths. Also: declare mockpay's provider routes an explicit exception to the collection-noun rule (api.md, a payments.md table, an ADR-017 amendment), and drop the retired POST /product/v1/internal/products from product.md and caching.md.
The wave-A release: payment serves the canonical protected paths beside their aliases, and the Backoffice calls the canonical ones. Both passed the full local-stack release audit from scratch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The homelab half of the ADR-017 expand step for the two payment Backoffice reads, plus the docs clean-up the owner asked for, plus the Kind pins for that release.
payments/attempts?status=openandpayments/reconciliation/runs[/:id]; old paths marked deprecated aliasesdocs/api/payments.md,docs/api/admin.md/charges…,/refunds,/transactions,/health): provider-API table + dated ADR-017 amendmentdocs/api/api.md,docs/api/payments.md,ADR-017/README.mdPOST /product/v1/internal/productsremoved; the caching section now describes the protected catalog writes and what each invalidatesdocs/api/product.md,docs/api/caching.mdscripts/k6/staff.js,local-stack/docs/e2e-audit.md2.6.1 → 2.7.0, admin-service0.4.2 → 0.4.3kubernetes/apps/services/payment.yaml,mockpay.yaml,backoffice-rs.yamlCHANGELOG.mdRelease gate (passed)
Full local-stack E2E release audit from scratch on payment
8f4a76aand admin948dd21, using this branch's runbook and k6 scripts.expired | timerpayments/attempts?status=openandpayments/reconciliation/runsand get 200Direct contract checks:
payments/attempts?status=open→ 200.status, orstatus=closed, → 400status must be open.payments/reconciliation/runs→ 200,/1→ 404,/abc→ 400./payments/1is still the case view.Playwright (admin-service): 17 passed.
catalog lists real productsfailed because, at that moment, no DRAFT product existed on the stack. It passed on a rerun once one did. This is a pre-existing data-order dependency in that spec.Tags: payment v2.7.0 and admin v0.4.3. Both have a signed image and a clean Trivy scan.
Verified on Kind (branch overlay, with #1194's controller 1.12 overlaid)
make e2e GATE=kind: A17–A22, K4.1–K4.8, K5.2–K5.9 and SG.1–SG.4 all PASS. A18 and A22 run on the canonical paths.make validatepasses.Next: contract
These are open as drafts, to ship after this one:
/public/track|estimate(v1.10.0).