Fix Hot Reload profile detection for web apps #48909
Open
+195
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area-AspNetCore
There was a problem hiding this comment.
Pull Request Overview
This PR fixes hot reload profile detection for web apps by updating the project capability checks and streamlining the web app detection logic. Key changes include:
- Adding a new IsWebApp extension method to correctly identify ASP.NET Core and WebAssembly projects.
- Revising the branching logic in HotReloadProfileReader to improve handling of web project capabilities.
- Updating delta applier instantiations and browser refresh support in CompilationHandler and BrowserConnector.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wwwroot/index.html | New basic HTML file for Blazor WebAssembly startup |
| wwwroot/css/app.css | Added an empty CSS class placeholder |
| _Imports.razor | Added necessary using directives |
| WatchAspire.Wasm.csproj | Updated project file with current target framework property and package references |
| launchSettings.json | Added development launch settings for local testing |
| Program.cs | Added minimal program entry point |
| Pages/Index.razor | Added a simple index page |
| App.razor | Updated routing configuration for the app |
| WatchAspire.AppHost.csproj | Updated project references for host configuration |
| ProjectGraphNodeExtensions.cs | Introduced new IsWebApp method using updated static lambda pattern |
| HotReloadProfileReader.cs | Revised logic for determining hot reload profile for web apps |
| CompilationHandler.cs | Updated delta applier creation with improved null checks |
| BrowserConnector.cs | Adjusted web app detection with added clarifying comments |
This was referenced May 13, 2025
Hona
reviewed
May 14, 2025
Co-authored-by: Luke Parker <[email protected]>
| return HotReloadProfile.BlazorWebAssembly; | ||
| if (item.EvaluatedInclude == "WebAssembly") | ||
| { | ||
| // We saw a previous project that was AspNetCore. This must he a blazor hosted app. |
There was a problem hiding this comment.
What if you receive the nodes in the opposite order (WebAssembly is in the list, and later AspNetCore)?
| public static readonly MessageDescriptor WaitingForFileChangeBeforeRestarting = new("Waiting for a file to change before restarting ...", "⏳", MessageSeverity.Warning, s_id++); | ||
| public static readonly MessageDescriptor WatchingWithHotReload = new("Watching with Hot Reload.", "⌚", MessageSeverity.Verbose, s_id++); | ||
| public static readonly MessageDescriptor WatchingWithHotReload = new("Watching with Hot Reload.", WatchEmoji, MessageSeverity.Verbose, s_id++); | ||
| public static readonly MessageDescriptor RestartInProgress = new("Restart in progress.", "🔄", MessageSeverity.Output, s_id++); | ||
| public static readonly MessageDescriptor RestartRequested = new("Restart requested.", "🔄", MessageSeverity.Output, s_id++); | ||
| public static readonly MessageDescriptor ShutdownRequested = new("Shutdown requested. Press Ctrl+C again to force exit.", "🛑", MessageSeverity.Output, s_id++); |
There was a problem hiding this comment.
One more emoji for the "Red Circle"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet-watch logic that distinguishes between hosted and standalone Blazor projects should not be applied to non-web projects (e.g. Aspire).
Fixes #48898