dotnet-watch tests failing

[dsplaisted]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888

Error Message

##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed

{
  "ErrorMessage": "",
  "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed",
  "BuildRetry": true,
  "ExcludeConsoleLog": true
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated: [Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
2964193	dotnet-sdk	Run TestBuild Tests	Log	#60657
1402970	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53847
2963887	dotnet-sdk	Run TestBuild Tests	Log	#60627
2963888	dotnet-sdk	Run FullFramework Tests	Log	#60628
1402794	dotnet/sdk	🟣 Run FullFramework Tests	Log	#54116
1402113	dotnet/sdk	🟣 Run FullFramework Tests	Log	#54115
2963221	dotnet-sdk	Run TestBuild Tests	Log	#60586
1401850	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53946
2963122	dotnet-sdk	Run FullFramework Tests	Log	#60361
2962905	dotnet-sdk	Run TestBuild Tests	Log	#60361
1386618	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53938
1396988	dotnet/sdk	Run TestBuild Tests	Log	#54073
1395510	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51088
2959060	dotnet-sdk	Run TestBuild Tests	Log	#60361
2959061	dotnet-sdk	Run TestBuild Tests	Log	#60362
1394265	dotnet/sdk	Run TestBuild Tests	Log	#54054
2958149	dotnet-sdk	Run FullFramework Tests	Log	#60361
2958182	dotnet-sdk	Run TestBuild Tests	Log	#60362
1391201	dotnet/sdk	Run FullFramework Tests	Log	#54042
1391145	dotnet/sdk	Run TestBuild Tests	Log	#54039
1390169	dotnet/sdk	Run TestBuild Tests	Log	#54028
1388783	dotnet/sdk	Run TestBuild Tests	Log	#53878
1388546	dotnet/sdk	Run FullFramework Tests	Log	#54010
1387770	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53976
1386437	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53988
1386435	dotnet/sdk	Run TestBuild Tests	Log	#53986
2954889	dotnet-sdk	Run TestBuild Tests	Log	#60249
2954890	dotnet-sdk	Run FullFramework Tests	Log	#60250
2954804	dotnet-sdk	Run TestBuild Tests	Log	#60242
2954691	dotnet-sdk	Run TestBuild Tests	Log	#60242
2954326	dotnet-sdk	Run TestBuild Tests	Log	#60216
1384700	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53820
1383449	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53934
2953195	dotnet-sdk	Run TestBuild Tests	Log	#59580
2953196	dotnet-sdk	Run FullFramework Tests	Log	#59579
1382659	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53925
1381243	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53777
2951749	dotnet-sdk	Run TestBuild Tests	Log	#59580
1380051	dotnet/sdk	Run TestBuild Tests	Log	#53864
2951750	dotnet-sdk	Run TestBuild Tests	Log	#59579
2951542	dotnet-sdk	Run FullFramework Tests	Log	#59580
1379700	dotnet/sdk	Run TestBuild Tests	Log	#53875
2951444	dotnet-sdk	Run TestBuild Tests	Log	#59580
1379364	dotnet/sdk	Run TestBuild Tests	Log	#53874
2951222	dotnet-sdk	Run FullFramework Tests	Log	#59580
1379303	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53795
2950411	dotnet-sdk	Run TestBuild Tests	Log	#59580
1377375	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53680
1375258	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53827
1374643	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53464
1374146	dotnet/sdk	Run FullFramework Tests	Log	#53811
1372449	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53175
1373478	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53800
1373686	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53803
1373664	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53535
1373046	dotnet/sdk	🟣 Run FullFramework Tests	Log	#53464
1371905	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53760
1371557	dotnet/sdk	Run TestBuild Tests	Log	#53745
1371498	dotnet/sdk	Run TestBuild Tests	Log	#53533
2946520	dotnet-sdk	Run TestBuild Tests	Log	#59942
1369726	dotnet/sdk	Run TestBuild Tests	Log	#53746
1369430	dotnet/sdk	Run TestBuild Tests	Log	#53728
1369290	dotnet/sdk	🟣 Run TestBuild Tests	Log	#53464
1369031	dotnet/sdk	Run TestBuild Tests	Log	#53740
1369027	dotnet/sdk	Run TestBuild Tests	Log	#53739

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	10	65

[marcpopMSFT]

@tmat we still see this fairly frequently. Any luck? Here's a recent one from a codeflow PR:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-41616-merge-58511284b77c40778a/dotnet-watch.Tests.dll.1/1/console.418de7ca.log?helixlogtype=result

[tmat]

No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json

It will print out test info every 20 seconds a test is running.

[marcpopMSFT]

@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result

[tmat]

Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963

[Forgind]

This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR:
#39618

I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before?

[Forgind]

The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild.