Skip to content

Couple fixes to AsyncResumptionStub #121759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

Couple fixes to AsyncResumptionStub #121759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/coreclr/tools/Common/TypeSystem/IL/Stubs/AsyncResumptionStub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ private MethodSignature InitializeSignature()
{
TypeDesc objectType = Context.GetWellKnownType(WellKnownType.Object);
TypeDesc byrefByte = Context.GetWellKnownType(WellKnownType.Byte).MakeByRefType();
return _signature = new MethodSignature(0, 0, objectType, [objectType, byrefByte]);
return _signature = new MethodSignature(MethodSignatureFlags.Static, 0, objectType, [objectType, byrefByte]);
}

public override MethodIL EmitIL()
Expand Down Expand Up @@ -132,11 +132,18 @@ public override MethodIL EmitIL()
internal sealed partial class ExplicitContinuationAsyncMethod : MethodDesc
{
private MethodSignature _signature;
private MethodDesc _wrappedMethod;
private readonly MethodDesc _wrappedMethod;
private readonly MethodDesc _typicalDefinition;

public ExplicitContinuationAsyncMethod(MethodDesc target)
{
_wrappedMethod = target;

MethodDesc targetTypicalDefinition = target.GetTypicalMethodDefinition();
if (targetTypicalDefinition != target)
_typicalDefinition = new ExplicitContinuationAsyncMethod(targetTypicalDefinition);
else
_typicalDefinition = this;
}

public MethodDesc Target => _wrappedMethod;
Expand Down Expand Up @@ -231,6 +238,8 @@ public override MethodSignature Signature
public override TypeSystemContext Context => _wrappedMethod.Context;

public override bool IsInternalCall => true;

public override MethodDesc GetTypicalMethodDefinition() => _typicalDefinition;
}

public static class AsyncResumptionStubExtensions
Expand Down
Loading