Couple fixes to AsyncResumptionStub #121759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The stub is static * The fake continuation method can act weird if the continuation owning method is on a generic type since we'll report the fake continuation method as homed on the same type. It can hit asserts expecting calling `GetTypicalMethodDefinition` will uninstantiate owning type. Make it so that this invariant holds.
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Copilot finished reviewing on behalf of
MichalStrehovsky
November 18, 2025 22:42
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two correctness issues in the AsyncResumptionStub implementation:
Key Changes:
- Adds the
Staticflag to the method signature ofAsyncResumptionStub, correcting the method's calling convention - Implements proper generic type handling in
ExplicitContinuationAsyncMethodby caching and returning the typical method definition, preventing assertion failures when continuation methods are on generic types
Member
Author
|
/ba-g osx related brownout issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTypicalMethodDefinitionwill uninstantiate owning type. Make it so that this invariant holds.Cc @dotnet/ilc-contrib