Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements #126

Merged
merged 4 commits into from
Dec 30, 2023
Merged

Code improvements #126

merged 4 commits into from
Dec 30, 2023

Conversation

williamdes
Copy link
Contributor

@williamdes williamdes commented Oct 18, 2023 •
edited
Loading

Fixes: #86

The only rename left for you is in composer.json for the namespace

@williamdes williamdes mentioned this pull request Oct 18, 2023
Merged
@bsweeney bsweeney added this to the 0.5.5 milestone Oct 18, 2023
@bsweeney bsweeney linked an issue Oct 18, 2023 that may be closed by this pull request
License mismatch #86
Closed
@bsweeney bsweeney merged commit 1afe786 into dompdf:master Dec 30, 2023
@williamdes williamdes deleted the code-improvements branch December 30, 2023 20:08
@williamdes
Copy link
Contributor Author

Can all this changes be released?

@bsweeney
Copy link
Member

I'm working on it. I have a few more things to finish up but should be soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsweeney bsweeney bsweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.5
Development

Successfully merging this pull request may close these issues.

License mismatch
2 participants
@williamdes @bsweeney