Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitattributes and remove bower.json + .htaccess #125

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Update .gitattributes and remove bower.json + .htaccess #125

merged 2 commits into from
Dec 30, 2023

Conversation

williamdes
Copy link
Contributor

No description provided.

@williamdes
Copy link
Contributor Author

Should I delete the file too?
The htaccess does nothing, delete also?

@williamdes
Copy link
Contributor Author

williamdes commented Oct 16, 2023 •
edited
Loading

Last question: should the composer.json namespace be updated?
Or only the homepage field?

@bsweeney
Copy link
Member

I think you're fine to delete those files. I was trying to decide the best time to update the namespace. I'm about ready to release a new version of Dompdf so I guess now would be a good time for it?

@williamdes
Copy link
Contributor Author

Yes definitely, I will not be on my workstation until this evening
Feel free to do the changes in the mean time and close this one
Can you give me some time to have a last check on my side that everything is ready for Debian too?
Maybe I have one more change to do, not very sure about it

@bsweeney bsweeney added this to the 0.5.5 milestone Oct 16, 2023
@williamdes
Copy link
Contributor Author

I think I am all done here

I removed one config param that is not used in phpunit since a long time (Author says: https://stackoverflow.com/a/44331140/5155484)

@williamdes
Copy link
Contributor Author

williamdes commented Oct 18, 2023 •
edited
Loading

Why does composer say this lib is LGPL 3.0 and the LICENSE file says it is 2.1 ?

Should it be LGPL-2.1-or-later (https://spdx.org/licenses/) ?

Changed in #126

@williamdes williamdes mentioned this pull request Oct 18, 2023
Merged
@williamdes williamdes changed the title Update .gitattributes to remove bower.json Update .gitattributes to remove bower.json + .htaccess Oct 18, 2023
@williamdes williamdes changed the title Update .gitattributes to remove bower.json + .htaccess Update .gitattributes and remove bower.json + .htaccess Oct 18, 2023
@bsweeney bsweeney merged commit a45ae21 into dompdf:master Dec 30, 2023
@williamdes williamdes deleted the patch-1 branch December 30, 2023 20:08
@bsweeney bsweeney mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsweeney bsweeney bsweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.5
Development

Successfully merging this pull request may close these issues.
2 participants
@williamdes @bsweeney