Skip to content

Remove this line #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericcurtin wants to merge 1 commit into from
Closed

Remove this line #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ Run `./model --help` to see all commands and options.
Or enter chat mode:
```bash
./model run llama.cpp
Interactive chat mode started. Type '/bye' to exit.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To keep the documentation consistent with the proposed change in run.go, this example should be updated to show the concise exit hint.

Suggested change
Interactive chat mode started. Type '/bye' to exit.
Type '/bye' to exit.

> """
Tell me a joke.
"""
Expand Down
2 changes: 0 additions & 2 deletions cmd/cli/commands/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,6 @@ func newRunCmd() *cobra.Command {
}

scanner := bufio.NewScanner(os.Stdin)
cmd.Println("Interactive chat mode started. Type '/bye' to exit.")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While reducing verbosity is a good goal, removing the hint for the /bye command might confuse new users as it's a non-standard way to exit. Consider keeping a concise hint that only contains the exit instruction. This would preserve usability while still making the output less verbose.

Suggested change
cmd.Println("Interactive chat mode started. Type '/bye' to exit.")
cmd.Println("Type '/bye' to exit.")


for {
userInput, err := readMultilineInput(cmd, scanner)
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion cmd/cli/docs/reference/docker_model_run.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ examples: |-
Output:

```console
Interactive chat mode started. Type '/bye' to exit.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To keep the documentation consistent with the proposed change in run.go, this example should be updated to show the concise exit hint.

    Type '/bye' to exit.

> Hi
Hi there! It's SmolLM, AI assistant. How can I help you today?
> /bye
Expand Down
1 change: 0 additions & 1 deletion cmd/cli/docs/reference/model_run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ docker model run ai/smollm2
Output:

```console
Interactive chat mode started. Type '/bye' to exit.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To keep the documentation consistent with the proposed change in run.go, this example should be updated to show the concise exit hint.

Suggested change
Interactive chat mode started. Type '/bye' to exit.
Type '/bye' to exit.

> Hi
Hi there! It's SmolLM, AI assistant. How can I help you today?
> /bye
Expand Down
Loading