Remove this line #229
Remove this line #229
Conversation
No other tool related does this, it's too verbose Signed-off-by: Eric Curtin <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the initial “Interactive chat mode started. Type '/bye' to exit.” notification from the interactive chat command implementation and cleans up all corresponding documentation entries to reduce verbosity. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the "Interactive chat mode started. Type '/bye' to exit." message from the CLI tool's output to reduce verbosity and align with other similar tools that don't display such messages.
- Removes the interactive chat mode startup message from the CLI code
- Updates documentation examples to reflect the cleaner output without the startup message
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/cli/commands/run.go | Removes the println statement that displays the startup message |
| cmd/cli/docs/reference/model_run.md | Updates example output to exclude the startup message |
| cmd/cli/docs/reference/docker_model_run.yaml | Updates YAML documentation example output |
| cmd/cli/README.md | Updates README example to show cleaner output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the user experience of the interactive chat mode by eliminating a redundant startup message. The change removes the 'Interactive chat mode started. Type '/bye' to exit.' line from both the application's code and its documentation, resulting in cleaner output and aligning the tool's behavior with common practices in similar applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to reduce verbosity by removing the "Interactive chat mode started" message. While this cleans up the output, it also removes the helpful hint on how to exit the interactive chat using the /bye command. Since /bye is not a standard exit command, its removal could be confusing for new users. I've provided suggestions to retain a concise exit hint in the code and update the documentation examples accordingly for better usability.
| Or enter chat mode: | ||
| ```bash | ||
| ./model run llama.cpp | ||
| Interactive chat mode started. Type '/bye' to exit. |
There was a problem hiding this comment.
To keep the documentation consistent with the proposed change in run.go, this example should be updated to show the concise exit hint.
| Interactive chat mode started. Type '/bye' to exit. | |
| Type '/bye' to exit. |
| } | ||
|
|
||
| scanner := bufio.NewScanner(os.Stdin) | ||
| cmd.Println("Interactive chat mode started. Type '/bye' to exit.") |
There was a problem hiding this comment.
While reducing verbosity is a good goal, removing the hint for the /bye command might confuse new users as it's a non-standard way to exit. Consider keeping a concise hint that only contains the exit instruction. This would preserve usability while still making the output less verbose.
| cmd.Println("Interactive chat mode started. Type '/bye' to exit.") | |
| cmd.Println("Type '/bye' to exit.") |
| Output: | ||
| ```console | ||
| Interactive chat mode started. Type '/bye' to exit. |
There was a problem hiding this comment.
To keep the documentation consistent with the proposed change in run.go, this example should be updated to show the concise exit hint.
Type '/bye' to exit.| Output: | ||
|
|
||
| ```console | ||
| Interactive chat mode started. Type '/bye' to exit. |
There was a problem hiding this comment.
To keep the documentation consistent with the proposed change in run.go, this example should be updated to show the concise exit hint.
| Interactive chat mode started. Type '/bye' to exit. | |
| Type '/bye' to exit. |
No other tool related does this, it's too verbose
Summary by Sourcery
Remove the verbose interactive chat start message from the CLI and documentation
Enhancements:
Documentation: