Skip to content

experiment with removing 'Real' from popular types #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Feb 18, 2025

Embedding Real type in most popular types would allow to simplify a bit the signatures of the functions:

from:

pub fn cast_shapes(
    pos1: &Isometry<f32>,
    vel1: &Vector<f32>,
    g1: &dyn Shape,
    pos2: &Isometry<f32>,
    vel2: &Vector<f32>,
    g2: &dyn Shape,
    options: ShapeCastOptions,
) -> Result<Option<ShapeCastHit>, Unsupported>

to:

pub fn cast_shapes(
    pos1: &Isometry,
    vel1: &Vector,
    g1: &dyn Shape,
    pos2: &Isometry,
    vel2: &Vector,
    g2: &dyn Shape,
    options: ShapeCastOptions,
) -> Result<Option<ShapeCastHit>, Unsupported>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant