-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google analytics log to form submission #35602
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
415df93
Add google analytics log to form submission
MartinRiese eb6e940
Breadcrumbs are only there if enabled
MartinRiese 9c911d4
Add GA event on navigate menu
MartinRiese a7b7cb2
Do not log to console
MartinRiese 10d1a53
Merge branch 'master' into riese/ga_form_submit
MartinRiese cd5de66
Merge branch 'master' into riese/ga_form_submit
orangejenny 3c8e5c1
Centralize web apps GA logging
MartinRiese 8870796
Merge branch 'riese/ga_form_submit' of github.com:dimagi/commcare-hq …
MartinRiese 4b1408d
Merge branch 'master' into riese/ga_form_submit
MartinRiese 2704bfb
Send dummy event to see what happens
MartinRiese da59cf9
Merge branch 'master' into riese/ga_form_submit
MartinRiese 021ee67
Clean up
MartinRiese e4cb800
Only send event when selection changes
MartinRiese e68b94b
Merge branch 'master' into riese/ga_form_submit
MartinRiese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
hqDefine('cloudcare/js/gtx', [ | ||
'underscore', | ||
'analytix/js/gtx', | ||
], function ( | ||
_, | ||
gtx, | ||
) { | ||
let lastCaseListSelections = ""; | ||
let lastCaseListTimeMs = Date.now(); | ||
let lastSelections = ""; | ||
let lastSelectionsChangeTimeMs = Date.now(); | ||
MartinRiese marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
const extractSelections = function (menuResponse) { | ||
return menuResponse.selections ? menuResponse.selections.join(">") : ""; | ||
}; | ||
AddisonDunn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
const logNavigateMenu = function (selections) { | ||
if (selections !== lastSelections) { | ||
const navigatedAwayFromCaseList = | ||
lastCaseListSelections !== "" && !selections.startsWith(lastCaseListSelections); | ||
const gtxEventData = { | ||
selections: selections, | ||
previousSelections: lastSelections, | ||
navigatedAwayFromCaseList: navigatedAwayFromCaseList, | ||
caseListSelection: lastCaseListSelections, | ||
timeSinceLastSelectionChangeMs: Date.now() - lastSelectionsChangeTimeMs, | ||
timeSinceLastCaseListOpenMs: Date.now() - lastCaseListTimeMs, | ||
}; | ||
lastSelections = selections; | ||
lastSelectionsChangeTimeMs = Date.now(); | ||
if (navigatedAwayFromCaseList) { | ||
lastCaseListSelections = ""; | ||
} | ||
gtx.sendEvent("web_apps_selection_change", gtxEventData); | ||
} | ||
}; | ||
|
||
const logCaseList = function (selections, gtxEventData) { | ||
_.extend(gtxEventData, { | ||
selections: selections, | ||
}); | ||
if (selections !== lastCaseListSelections) { | ||
lastCaseListSelections = selections; | ||
lastCaseListTimeMs = Date.now(); | ||
} | ||
gtx.sendEvent("web_apps_viewed_case_list", gtxEventData); | ||
}; | ||
|
||
const logFormSubmit = function (gtxEventData) { | ||
_.extend(gtxEventData, { | ||
navigatedAwayFromCaseList: true, | ||
timeSinceLastCaseListOpenMs: Date.now() - lastCaseListTimeMs, | ||
caseListSelection: lastCaseListSelections, | ||
}); | ||
lastCaseListSelections = ""; | ||
gtx.sendEvent("web_apps_submit_form", gtxEventData); | ||
}; | ||
|
||
return { | ||
extractSelections: extractSelections, | ||
logCaseList: logCaseList, | ||
logFormSubmit: logFormSubmit, | ||
logNavigateMenu: logNavigateMenu, | ||
}; | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you grab breadcrumbs here instead of selections? I'm guessing cause you don't have access to selections here?