Add google analytics log to form submission #35602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: Medium
…into riese/ga_form_submit
MartinRiese
requested review from
AddisonDunn,
stephherbers,
Robert-Costello,
Jtang-1 and
nospame
as code owners
AddisonDunn
reviewed
Feb 6, 2025
AddisonDunn
approved these changes
Feb 10, 2025
| @@ -543,6 +545,11 @@ hqDefine("cloudcare/js/form_entry/web_form_session", [ | |||
| function (resp) { | |||
| form.isSubmitting(false); | |||
| if (resp.status === 'success') { | |||
| const gtxEventData = { | |||
| title: form.title(), | |||
| breadcrumbs: form.breadcrumbs() ? form.breadcrumbs().join(">") : "", | |||
There was a problem hiding this comment.
Why do you grab breadcrumbs here instead of selections? I'm guessing cause you don't have access to selections here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Add google analytics event for when successfully submitting a form.
These are mostly necessary because there is not way to get duration between events after the fact. So we need to track them client side and send them to google analytics precomputed.
Technical Summary
https://dimagi.atlassian.net/browse/USH-5193
Feature Flag
No
Safety Assurance
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review