Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fiber aperture correction: normalization and sky fibers #2454

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Fix fiber aperture correction: normalization and sky fibers #2454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions py/desispec/fiberfluxcorr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,16 @@ def flat_to_psf_flux_correction(fibermap,exposure_seeing_fwhm=1.1) :
# fiber flat correction is larger
# have to divide by isotropic_platescale^2
ok = (fiber_frac>0.01)
skyfibers = fibermap["OBJTYPE"]=="SKY"
ok &= (~skyfibers) # also exclude sky fibers from the point_source_correction calculation
point_source_correction = np.zeros(x_mm.shape)
point_source_correction[ok] = 1./fiber_frac[ok]/isotropic_platescale[ok]**2

# normalize to one because this is a relative correction here
point_source_correction[ok] /= np.mean(point_source_correction[ok])
# normalize to one because this is a relative correction here; use median to be robust against outliers
point_source_correction[ok] /= np.median(point_source_correction[ok])

# set the correction factor to 1 for sky fibers; other low-fiber_frac fibers have value 0.
point_source_correction[skyfibers] = 1.

return point_source_correction

Expand Down
Loading