Fix fiber aperture correction: normalization and sky fibers #2454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include two changes to fluxcalib:
point_source_correction
normalization calculation; sky fibers are now always assignedpoint_source_correction=1
;Before this fix, fibers with very large fiber positioning offsets (mostly used as sky fibers) biases the normalization calculation, causing the
FLAT_TO_PSF_FLUX
value (point_source_correction
in the code) to be significantly lower than 1 for the "good" fibers (see below the per-petal medianFLAT_TO_PSF_FLUX
value for 100 random tiles). Fortunately, downstream code cancels out this "correction" and the final flux calibration is unbiased for the good fibers. In addition to bringing theFLAT_TO_PSF_FLUX
value back to a small correction around 1 as originally intended, with this PR we also fix the flux calibration of sky fibers which effectively had arbitrary normalization due to this "aperture correction".I have tested the new code on one blue camera of a dark-time tile, and the changes to fluxcalib is very small (<1%) for all fibers except for sky fibers which now have the reasonable fluxcalib.