Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/node-local-dns]: Add option to enable logging #622

Merged
merged 2 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/node-local-dns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: node-local-dns
version: 2.1.0
version: 2.1.1
appVersion: 1.23.1
maintainers:
- name: gabrieladt
Expand Down
5 changes: 3 additions & 2 deletions stable/node-local-dns/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# node-local-dns

![Version: 2.1.0](https://img.shields.io/badge/Version-2.1.0-informational?style=flat-square) ![AppVersion: 1.23.1](https://img.shields.io/badge/AppVersion-1.23.1-informational?style=flat-square)
![Version: 2.1.1](https://img.shields.io/badge/Version-2.1.1-informational?style=flat-square) ![AppVersion: 1.23.1](https://img.shields.io/badge/AppVersion-1.23.1-informational?style=flat-square)

A chart to install node-local-dns.

Expand All @@ -23,7 +23,7 @@ helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-d
To install a specific version of this chart:

```console
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.1.0
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.1.1
```

To install the chart with the release name `my-release`:
Expand Down Expand Up @@ -55,6 +55,7 @@ helm install my-release oci://ghcr.io/deliveryhero/helm-charts/node-local-dns -f
| config.customUpstreamsvc | string | `""` | Use a custom upstreamsvc for -upstreamsvc |
| config.dnsDomain | string | `"cluster.local"` | Internal k8s DNS domain |
| config.dnsServer | string | `"172.20.0.10"` | Main coredns service (kube-dns) ip, used on iptables-mode. |
| config.enableLogging | bool | `false` | Set boolean to log DNS requests |
| config.healthPort | int | `8080` | Port used for the health endpoint |
| config.localDns | string | `"169.254.20.25"` | |
| config.noIPv6Lookups | bool | `false` | If true, return NOERROR when attempting to resolve an IPv6 address |
Expand Down
6 changes: 6 additions & 0 deletions stable/node-local-dns/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ data:
{{- tpl .Values.config.customConfig . | nindent 4}}
{{- else }}
{{ .Values.config.dnsDomain }}:53 {
{{- if .Values.config.enableLogging }}
log
{{- end }}
errors
cache {
success 9984 30
Expand Down Expand Up @@ -91,6 +94,9 @@ data:
prometheus :9253
}
.:53 {
{{- if .Values.config.enableLogging}}
log
{{- end }}
errors
{{- if .Values.config.prefetch.enabled}}
cache 30 {
Expand Down
3 changes: 3 additions & 0 deletions stable/node-local-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ config:
# -- Set communication protocol. Options are `prefer_udp` or `force_tcp`
commProtocol: "force_tcp"

# -- Set boolean to log DNS requests
enableLogging: false

# -- If true, return NOERROR when attempting to resolve an IPv6 address
noIPv6Lookups: false

Expand Down
Loading