Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns]: Add option to enable logging #622

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[stable/node-local-dns]: Add option to enable logging #622

merged 2 commits into from
Oct 29, 2024

Conversation

apurandare-aurva
Copy link
Contributor

@apurandare-aurva apurandare-aurva commented Oct 29, 2024 •
edited
Loading

Description

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@apurandare-aurva apurandare-aurva changed the title Add option to enable logging in node-local-dns [stable/node-local-dns] Add option to enable logging in node-local-dns Oct 29, 2024
@apurandare-aurva apurandare-aurva changed the title [stable/node-local-dns] Add option to enable logging in node-local-dns [stable/node-local-dns] Add option to enable logging Oct 29, 2024
@apurandare-aurva apurandare-aurva changed the title [stable/node-local-dns] Add option to enable logging [stable/node-local-dns]: Add option to enable logging Oct 29, 2024
@apurandare-aurva apurandare-aurva marked this pull request as ready for review October 29, 2024 13:05
@apurandare-aurva apurandare-aurva requested a review from a team as a code owner October 29, 2024 13:05
max-rocket-internet
max-rocket-internet approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apurandare-aurva 💛

@max-rocket-internet max-rocket-internet merged commit b40abbc into deliveryhero:master Oct 29, 2024
6 checks passed
@apurandare-aurva apurandare-aurva deleted the patch-1 branch October 30, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apurandare-aurva @max-rocket-internet