fix(observability): preserve engine span resource identity#1
Open
alsruf36 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service.name,service.version, and optionalservice.namespaceto the engine tracer provider resource.TeeSpanExportersoOTEL_EXPORTER_TYPE=bothexports the same service identity to external OTLP collectors.Test Plan
cargo test -p iii --test otel_tracer_provider_resource_testcargo test -p iii --test otel_tracer_provider_both_resource_testcargo test -p iii --test otel_forwarder_resource_testcargo fmt --all --checkNotes
This PR is stacked on top of iii-hq#1618 (
fix/1617-otlp-resource-forwarding). iii-hq#1618 fixes SDK-forwarded spans by preserving inbound OTLP resources; this PR fixes the separate engine-originatedSdkTracerProviderexport path for iii-hq#1619.Live verification with
OTEL_EXPORTER_TYPE=bothconfirmed SigNoz now receives the expected engine service identity instead of the collector/backend fallback<nil>.