feat(api): add specification validation for correct VMI creation #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eofff
force-pushed
the
feat/api/kubevirt-like-validation
branch
from
714aa1b to
f1d82c9
Compare
Isteb4k
requested changes
Jan 22, 2025
images/virtualization-artifact/pkg/controller/vm/internal/validators/affinity_validator.go
Outdated
Show resolved
Hide resolved
...s/virtualization-artifact/pkg/controller/vm/internal/validators/topology_spread_validator.go
Outdated
Show resolved
Hide resolved
eofff
force-pushed
the
feat/api/kubevirt-like-validation
branch
2 times, most recently
from
81e3e27 to
11230d5
Compare
eofff
force-pushed
the
feat/api/kubevirt-like-validation
branch
from
43f42db to
8dd4ea6
Compare
added 3 commits
January 27, 2025 16:29
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff
force-pushed
the
feat/api/kubevirt-like-validation
branch
from
8dd4ea6 to
d1fe2e9
Compare
Isteb4k
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add VirtualMachine specification validation by affinity and topologySpreadConstraints.
Add block devices name validation (must no contains dots).
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist