Skip to content

Commit

Permalink
refactoring
Browse files Browse the repository at this point in the history
Signed-off-by: Valeriy Khorunzhin <[email protected]>
  • Loading branch information
Valeriy Khorunzhin committed Jan 27, 2025
1 parent 886a3aa commit 43f42db
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package validators

import (
"context"
"errors"
"fmt"

k8sfield "k8s.io/apimachinery/pkg/util/validation/field"
Expand All @@ -43,15 +42,10 @@ func (v *AffinityValidator) ValidateUpdate(_ context.Context, _, newVM *v1alpha2
}

func (v *AffinityValidator) Validate(vm *v1alpha2.VirtualMachine) (admission.Warnings, error) {
var errs []error

errorList := k8sUtils.ValidateAffinity(vm.Spec.Affinity, k8sfield.NewPath("spec"))
for _, err := range errorList {
errs = append(errs, err)
}
errs := k8sUtils.ValidateAffinity(vm.Spec.Affinity, k8sfield.NewPath("spec"))

if len(errs) > 0 {
return nil, fmt.Errorf("errors while validating affinity: %w", errors.Join(errs...))
return nil, fmt.Errorf("errors while validating affinity: %w", errs.ToAggregate())
}

return nil, nil
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package validators

import (
"context"
"errors"
"fmt"

k8sfield "k8s.io/apimachinery/pkg/util/validation/field"
Expand All @@ -43,18 +42,13 @@ func (v *TopologySpreadConstraintValidator) ValidateUpdate(_ context.Context, _,
}

func (v *TopologySpreadConstraintValidator) Validate(vm *v1alpha2.VirtualMachine) (admission.Warnings, error) {
var errs []error

errorList := k8sUtils.ValidateTopologySpreadConstraints(
errs := k8sUtils.ValidateTopologySpreadConstraints(
vm.Spec.TopologySpreadConstraints,
k8sfield.NewPath("spec").Child("topologySpreadConstraints"),
)
for _, err := range errorList {
errs = append(errs, err)
}

if len(errs) > 0 {
return nil, fmt.Errorf("errors while validating topology spread constraints: %w", errors.Join(errs...))
return nil, fmt.Errorf("errors while validating topology spread constraints: %w", errs.ToAggregate())
}

return nil, nil
Expand Down

0 comments on commit 43f42db

Please sign in to comment.