fix(f1002): Add missing p1, p2, p3 columns to most_podiums solution#138
Open
sfc-gh-zblackwood wants to merge 1 commit intodbt-labs:mainfrom
Open
fix(f1002): Add missing p1, p2, p3 columns to most_podiums solution#138sfc-gh-zblackwood wants to merge 1 commit intodbt-labs:mainfrom
sfc-gh-zblackwood wants to merge 1 commit intodbt-labs:mainfrom
Conversation
The __stats.yml spec defines most_podiums with 6 columns (rank, driver_full_name, podiums, p1, p2, p3) but the solution and seed CSV only included 3 (rank, driver_full_name, podiums). This updates both the solution SQL and the seed CSV to match the yml spec. .... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-Authored-By: Cortex Code <[email protected]>
sfc-gh-zblackwood
force-pushed
the
zb/fix-f1002-most-podiums
branch
from
0dd38df to
b47779e
Compare
Collaborator
|
@sfc-gh-zblackwood good catch! The shared project ( |
Contributor
Author
|
Hi @joellabes, I'm happy to switch it that way. The only downside I see is that it makes the task easier, since it simplifies the spec that it has to follow. |
sfc-gh-zblackwood
added a commit
to sfc-gh-zblackwood/ade-bench
that referenced
this pull request
Mar 30, 2026
The shared project's most_podiums.sql only selects rank, driver_full_name, and podiums — it does not include p1/p2/p3. Rather than adding columns to the solution and seed, this aligns the yml spec to the existing model. Alternate approach to dbt-labs#138 per @joellabes's suggestion. .... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-Authored-By: Cortex Code <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__stats.ymlspec definesmost_podiumswith 6 columns (rank,driver_full_name,podiums,p1,p2,p3) but the solution SQL and seed CSV only included 3 columns (rank,driver_full_name,podiums)tasks/f1002/solutions/most_podiums.sqlto selectp1,p2,p3fromfinishes_by_drivertasks/f1002/seeds/solution__most_podiums.csvwith the correct data including the breakdown columnsImpact
This isn't just a cosmetic fix — an agent that correctly reads the YML spec and includes
p1,p2,p3will fail theAUTO_most_podiums_equalitytest against the old seed. The old solution only passed because both the seed and the solution were missing the same columns. Correct agents are actively penalized by the current task.Context
dbt_utils.test_equalitycompares all columns present in either table (not just the intersection). So when a correct model includesp1/p2/p3but the seed doesn't, the equality check fails. The bug went unnoticed because the official solution was also missing those columns, making the seed and model match on their (incomplete) shared schema.Test plan
AUTO_most_podiums_equality(10/11 pass)ade run f1002 --db duckdb --project-type dbt --agent sage