fix(f1002): Remove p1, p2, p3 from most_podiums yml spec#141
Open
sfc-gh-zblackwood wants to merge 1 commit intodbt-labs:mainfrom
Open
fix(f1002): Remove p1, p2, p3 from most_podiums yml spec#141sfc-gh-zblackwood wants to merge 1 commit intodbt-labs:mainfrom
sfc-gh-zblackwood wants to merge 1 commit intodbt-labs:mainfrom
Conversation
The shared project's most_podiums.sql only selects rank, driver_full_name, and podiums — it does not include p1/p2/p3. Rather than adding columns to the solution and seed, this aligns the yml spec to the existing model. Alternate approach to dbt-labs#138 per @joellabes's suggestion. .... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-Authored-By: Cortex Code <noreply@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate approach to #138 per @joellabes suggestion: instead of adding p1/p2/p3 to the solution SQL and seed CSV, this removes them from the __stats.yml spec to match what the shared most_podiums.sql already produces.
Changes:
Impact:
Trade-off vs #138:
This is simpler (1 file, net -9 lines) but makes f1002 a slightly easier eval since agents no longer need to figure out the position breakdown columns.
Test plan: