Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean error and useless tests #9233

Merged
merged 3 commits into from
Dec 14, 2022
Merged

chore: clean error and useless tests #9233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
888cda3
chore: clean error and useless tests
xudong963 Dec 13, 2022
2707bf2
fix
xudong963 Dec 13, 2022
9f01d96
update
xudong963 Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 8 additions & 53 deletions tests/logictest/suites/base/05_ddl/05_0003_ddl_alter_database
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,75 +38,43 @@ statement ok
ALTER DATABASE IF EXISTS c RENAME TO a;

statement query T
SELECT name FROM system.databases;
SELECT name FROM system.databases where name = 'a' or name = 'b';

----
system
information_schema
a
b
default

statement ok
ALTER DATABASE IF EXISTS c RENAME TO C;

statement error 1003
ALTER DATABASE c RENAME TO C;

statement query T
SELECT name FROM system.databases;

----
system
information_schema
a
b
default
-- don't exist database c, so the result will be empty
statement ok
SELECT name FROM system.databases where name = 'c';

statement error 1002
ALTER DATABASE IF EXISTS system RENAME TO C;

statement error 1002
ALTER DATABASE system RENAME TO C;

statement query T
SELECT name FROM system.databases;

----
system
information_schema
a
b
default

statement error 2301
ALTER DATABASE a RENAME TO b;

statement error 2301
ALTER DATABASE IF EXISTS a RENAME TO b;

statement query T
SELECT name FROM system.databases;

----
system
information_schema
a
b
default

statement ok
ALTER DATABASE a RENAME TO a2;

-- check if change a to `a2` successfully
statement query T
SELECT name FROM system.databases;
SELECT name FROM system.databases where name = 'a2';

----
system
information_schema
a2
b
default

statement query I
SELECT * FROM a2.t1;
Expand All @@ -126,16 +94,6 @@ SELECT * FROM b.t2;
----
10

statement query T
SELECT name FROM system.databases;

----
system
information_schema
a2
b
default

statement ok
ALTER DATABASE default.b RENAME TO b2;

Expand All @@ -145,15 +103,12 @@ SELECT * FROM b2.t2;
----
10


statement query T
SELECT name FROM system.databases;
SELECT name FROM system.databases where name = 'b2';

----
system
information_schema
a2
b2
default

statement ok
DROP DATABASE b2;
Expand Down
6 changes: 0 additions & 6 deletions tests/logictest/suites/base/05_ddl/05_0024_ddl_set_role
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
statement ok
CREATE ROLE IF NOT EXISTS 'test-s'

statement query T
SELECT current_role()

----
account_admin

onlyif mysql
statement ok
SET ROLE 'test-s'
Expand Down
6 changes: 6 additions & 0 deletions tests/logictest/suites/base/06_show/06_0003_show_settings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
statement ok
unset max_threads;

statement ok
unset max_memory_usage;

statement query B
select value=default from system.settings where name in ('max_threads', 'max_memory_usage') order by name;

Expand Down
10 changes: 5 additions & 5 deletions tests/logictest/suites/base/06_show/06_0007_show_roles
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
statement ok
CREATE ROLE IF NOT EXISTS 'test';

statement query TIII
SHOW ROLES;
statement query T
select name from system.roles;

----
account_admin 0 1 1
public 0 0 0
test 0 0 0
account_admin
public
test

statement ok
DROP ROLE 'test';
Expand Down
122 changes: 0 additions & 122 deletions tests/logictest/suites/base/06_show/06_0012_show_table_status
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions tests/logictest/suites/base/09_fuse_engine/09_0001_remote_insert
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ SELECT * FROM t2;
1 2021-09-07 21:38:35.000000 2021-09-07
0 2021-09-07 21:38:35.000000 2021-09-07

2021-09-07 21:38:35.000000 2021-09-07
false 2021-09-07 21:38:35.000000 2021-09-07

statement ok
DROP TABLE t1;

Expand Down
3 changes: 0 additions & 3 deletions tests/logictest/suites/base/09_fuse_engine/09_0001_remote_insert_v2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ SELECT * FROM t2;
1 2021-09-07 21:38:35.000000 2021-09-07
0 2021-09-07 21:38:35.000000 2021-09-07

2021-09-07 21:38:35.000000 2021-09-07
false 2021-09-07 21:38:35.000000 2021-09-07

statement ok
DROP TABLE t1;

Expand Down
2 changes: 0 additions & 2 deletions tests/logictest/suites/base/09_fuse_engine/09_0010_remote_insert_overwrite_v2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


statement ok
DROP DATABASE IF EXISTS db1;

Expand Down
4 changes: 3 additions & 1 deletion tests/logictest/suites/base/09_fuse_engine/09_0019_issue_8831
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ select count(1) from t1;
----
7


statement ok
DROP TABLE t;

statement ok
DROP TABLE t1;

statement ok
Expand Down
4 changes: 1 addition & 3 deletions tests/logictest/suites/base/09_fuse_engine/09_0020_analyze
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,9 @@ select * from t order by a;
6
7

statement query T
statement ok
select * from fuse_statistic('db_09_0020', 't');

----


statement ok
analyze table `t`;
Expand Down
5 changes: 1 addition & 4 deletions tests/logictest/suites/base/20+_others/20_0008_where_optimization
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,9 @@ select * from t_where_optimizer where a = b order by a;

-- All rows are filtered out

statement query II
statement ok
select * from t_where_optimizer where a < 1;

----


-- One part will be filtered out

statement query I
Expand Down