Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean error and useless tests #9233

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Conversation

xudong963
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

When I work on #9150, I found some strange and useless tests... 😅

I have some suggestions for tests:

  1. For reviewers, we should review tests carefully too.
  2. For tests writers, we should focus on test points to avoid useless tests.
  3. Consider if tests that you write will be influenced by other files and even become flaky tests.

Closes #issue

@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Dec 13, 2022 at 3:24PM (UTC)

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 13, 2022
@xudong963
Copy link
Contributor Author

Strange..

image

Any thoughts?

@TCeason
Copy link
Collaborator

TCeason commented Dec 13, 2022

Strange..

image

Any thoughts?

Not *.

statement query T
SELECT name FROM system.databases where name = 'a' or name = 'b';

----
a
b
'u1'@mysqldb 22:41:26 [default]> SELECT * FROM system.databases where name = 'a' or name = 'b';
+---------+------+
| catalog | name |
+---------+------+
| default | a    |
| default | b    |
+---------+------+
2 rows in set (0.08 sec)
Read 9 rows, 286.00 B in 0.020 sec., 442.51 rows/sec., 13.73 KiB/sec.

'u1'@mysqldb 22:41:32 [default]> SELECT name FROM system.databases where name = 'a' or name = 'b';
+------+
| name |
+------+
| a    |
| b    |
+------+
2 rows in set (0.06 sec)
Read 9 rows, 286.00 B in 0.016 sec., 545.55 rows/sec., 16.93 KiB/sec.

@BohuTANG BohuTANG merged commit 1d3dbcf into databendlabs:main Dec 14, 2022
@xudong963 xudong963 deleted the test1 branch December 14, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants