Skip to content

refactor(binder): move the rewrite of ASOF JOIN to the logical plan and remove scalar_expr from DerivedColumn #18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 10, 2025
Merged

refactor(binder): move the rewrite of ASOF JOIN to the logical plan and remove scalar_expr from DerivedColumn #18938

merged 5 commits into from
Nov 10, 2025

Conversation

@forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Nov 7, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

scalar_expr in metadata is not reliable, so remove it.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@forsaken628 forsaken628 changed the title refacror(binder): asof refactor(binder): asof Nov 7, 2025
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 7, 2025
@forsaken628 forsaken628 changed the title refactor(binder): asof refactor(binder): move the rewrite of ASOF JOIN to the logical plan and remove scalar_expr from DerivedColumn Nov 8, 2025
@forsaken628 forsaken628 marked this pull request as ready for review November 8, 2025 02:41
@BohuTANG BohuTANG merged commit 3b47ead into databendlabs:main Nov 10, 2025
258 of 262 checks passed
@forsaken628 forsaken628 deleted the binder branch November 10, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KKould KKould KKould approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees

No one assigned

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@forsaken628 @KKould @BohuTANG