is_asof_join

Author: forsaken628

src/query/service/src/physical_plans/physical_join.rs

@@ -164,10 +164,7 @@ impl PhysicalPlanBuilder {
 
         // 2. Build physical plan.
         // Choose physical join type by join conditions
-        if matches!(
-            join.join_type,
-            JoinType::Asof | JoinType::LeftAsof | JoinType::RightAsof
-        ) {
+        if join.join_type.is_asof_join() {
             let left_rel_expr = RelExpr::with_s_expr(s_expr.left_child());
             let right_rel_expr = RelExpr::with_s_expr(s_expr.right_child());
             let left_prop = left_rel_expr.derive_relational_prop()?;

src/query/sql/src/planner/binder/bind_table_reference/bind_join.rs

@@ -452,10 +452,7 @@ impl Binder {
             build_side_cache_info,
         };
 
-        if matches!(
-            logical_join.join_type,
-            JoinType::Asof | JoinType::LeftAsof | JoinType::RightAsof
-        ) {
+        if logical_join.join_type.is_asof_join() {
             self.rewrite_asof(logical_join, left_child, right_child)
         } else {
             Ok(SExpr::create_binary(

src/query/sql/src/planner/plans/join.rs

@@ -118,6 +118,13 @@ impl JoinType {
             JoinType::InnerAny | JoinType::LeftAny | JoinType::RightAny
         )
     }
+
+    pub fn is_asof_join(&self) -> bool {
+        matches!(
+            self,
+            JoinType::Asof | JoinType::LeftAsof | JoinType::RightAsof
+        )
+    }
 }
 
 impl Display for JoinType {