Skip to content

chore: update GitHub Actions to use ubuntu-22.04-arm for all jobs #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

chore: update GitHub Actions to use ubuntu-22.04-arm for all jobs #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbc1dd9
chore: update GitHub Actions to use ubuntu-22.04-arm for all jobs
PastaPastaPasta Nov 1, 2025
69741e7
fix(ffi): use c_char instead of i8 for platform-agnostic FFI types
PastaPastaPasta Nov 4, 2025
3ab3beb
fix(ffi): use .cast() instead of as cast for raw pointer conversion
PastaPastaPasta Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/fuzz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ concurrency:
jobs:
fuzz:
if: ${{ !github.event.act }}
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
verify-execution:
if: ${{ !github.event.act }}
needs: fuzz
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
permissions:
contents: read
pull-requests: write
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout Crate
uses: actions/checkout@v4
Expand Down Expand Up @@ -56,7 +56,7 @@
id: segvscan
if: ${{ steps.spvtest.outputs.segv == 'true' }}
shell: bash
run: |

Check warning on line 59 in .github/workflows/rust.yml

View workflow job for this annotation

GitHub Actions / Lint GitHub Actions 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:17:10: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/rust.yml:59:9: shellcheck reported issue in this script: SC2086:info:17:10: Double quote to prevent globbing and word splitting [shellcheck]
set +e
echo "Detected SIGSEGV in parallel run; scanning tests sequentially..."
# List all tests for the crate
Expand Down Expand Up @@ -140,7 +140,7 @@

key_wallet_tests:
name: Key Wallet Components Tests
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout Crate
uses: actions/checkout@v4
Expand All @@ -157,7 +157,7 @@

core_components_tests:
name: Core Components Tests
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout Crate
uses: actions/checkout@v4
Expand All @@ -178,7 +178,7 @@

clippy:
name: Clippy (Non-strict)
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout Crate
uses: actions/checkout@v4
Expand All @@ -201,7 +201,7 @@

strict-checks:
name: Strict Warnings and Clippy Checks
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout Crate
uses: actions/checkout@v4
Expand Down Expand Up @@ -298,7 +298,7 @@

fmt:
name: Format
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout Crate
uses: actions/checkout@v4
Expand All @@ -311,7 +311,7 @@

rpc_tests:
name: RPC Tests
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
strategy:
matrix:
include:
Expand All @@ -330,7 +330,7 @@
integrations_tests:
name: Integration Tests
if: ${{ false }} # Temporarily disabled
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
strategy:
matrix:
rust: [stable]
Expand All @@ -347,7 +347,7 @@

actionlint:
name: Lint GitHub Actions
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
permissions:
contents: read
steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/verify-ffi-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:

jobs:
verify-key-wallet-docs:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
fi

verify-dash-spv-docs:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
fi

update-docs-comment:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-arm
if: failure() && github.event_name == 'pull_request'
needs:
- verify-key-wallet-docs
Expand Down
4 changes: 3 additions & 1 deletion key-wallet-ffi/src/account_derivation_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ mod tests {
use crate::keys::{extended_private_key_free, private_key_free};
use crate::types::{FFIAccountType, FFINetworks};
use crate::wallet;
use std::ffi::CString;
use std::os::raw::c_char;

const MNEMONIC: &str =
"abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about";
Expand Down Expand Up @@ -215,7 +217,7 @@ mod tests {
}

// Helper to make C string pointers
fn c_str(s: &str) -> *const i8 {
fn c_str(s: &str) -> *const c_char {
std::ffi::CString::new(s).unwrap().as_ptr()
}
}
12 changes: 6 additions & 6 deletions key-wallet-ffi/src/derivation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ pub extern "C" fn derivation_bip44_account_path(
}

unsafe {
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
}

FFIError::set_success(error);
Expand Down Expand Up @@ -189,7 +189,7 @@ pub extern "C" fn derivation_bip44_payment_path(
}

unsafe {
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
}

FFIError::set_success(error);
Expand Down Expand Up @@ -244,7 +244,7 @@ pub extern "C" fn derivation_coinjoin_path(
}

unsafe {
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
}

FFIError::set_success(error);
Expand Down Expand Up @@ -299,7 +299,7 @@ pub extern "C" fn derivation_identity_registration_path(
}

unsafe {
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
}

FFIError::set_success(error);
Expand Down Expand Up @@ -356,7 +356,7 @@ pub extern "C" fn derivation_identity_topup_path(
}

unsafe {
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
}

FFIError::set_success(error);
Expand Down Expand Up @@ -417,7 +417,7 @@ pub extern "C" fn derivation_identity_authentication_path(
}

unsafe {
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
}

FFIError::set_success(error);
Expand Down
Loading
Loading