Skip to content

Conversation

@PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented Nov 1, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI runner environment to Ubuntu 22.04 (ARM) across multiple workflows to align build infrastructure and improve consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2025

Walkthrough

Three GitHub Actions workflow files are updated to specify ubuntu-22.04-arm as the runner for all jobs, replacing ubuntu-latest. No behavioral, logic, or job step changes were made—only the runner platform was changed.

Changes

Cohort / File(s) Summary
GitHub Actions runner updates
.github/workflows/fuzz.yml, .github/workflows/rust.yml, .github/workflows/verify-ffi-docs.yml
Replaced runs-on: ubuntu-latest with runs-on: ubuntu-22.04-arm for all jobs across these workflow files. No other steps, logic, or configuration changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Changes are homogeneous string replacements across three workflow files.
  • Review focus: verify each job's runs-on lines were changed and no other lines were modified.

Poem

🐰 ARM runners hum in tune,
Ubuntu twenty-two beneath the moon,
Workflows hop to a narrower track,
Nothing else altered, just the stack,
Small change, steady tune — hop on!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "chore: update GitHub Actions to use ubuntu-22.04-arm for all jobs" accurately and comprehensively summarizes the main change across all three modified workflow files. The title is fully related to the changeset, which consistently updates runner specifications from ubuntu-latest to ubuntu-22.04-arm across .github/workflows/fuzz.yml, .github/workflows/rust.yml, and .github/workflows/verify-ffi-docs.yml. The title is concise, specific, and avoids vague terminology, making it immediately clear to teammates reviewing the history what the primary change entails.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/run-on-arm

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ed44a6 and cbc1dd9.

📒 Files selected for processing (3)
  • .github/workflows/fuzz.yml (2 hunks)
  • .github/workflows/rust.yml (9 hunks)
  • .github/workflows/verify-ffi-docs.yml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/fuzz.yml
  • .github/workflows/verify-ffi-docs.yml
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-29T04:01:18.111Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: key-wallet/CLAUDE.md:0-0
Timestamp: 2025-08-29T04:01:18.111Z
Learning: Applies to key-wallet/tests/**/*.rs : Include integration tests that cover full wallet workflows

Applied to files:

  • .github/workflows/rust.yml
📚 Learning: 2025-09-01T14:44:53.683Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-01T14:44:53.683Z
Learning: Applies to **/*.rs : Lint with clippy; treat warnings as errors in CI

Applied to files:

  • .github/workflows/rust.yml
📚 Learning: 2025-08-29T04:00:14.154Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-29T04:00:14.154Z
Learning: Applies to **/*.rs : Run clippy with -D warnings and fix all lints

Applied to files:

  • .github/workflows/rust.yml
📚 Learning: 2025-09-01T14:44:53.683Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-09-01T14:44:53.683Z
Learning: Applies to **/tests/**/*.rs : Integration tests must live under tests/ (e.g., rpc-integration-test)

Applied to files:

  • .github/workflows/rust.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
  • GitHub Check: verify-dash-spv-docs
  • GitHub Check: fuzz (hashes_sha512)
  • GitHub Check: fuzz (hashes_ripemd160)
  • GitHub Check: fuzz (hashes_sha1)
  • GitHub Check: fuzz (hashes_json)
  • GitHub Check: fuzz (dash_deserialize_witness)
  • GitHub Check: fuzz (dash_deserialize_block)
  • GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
  • GitHub Check: fuzz (dash_outpoint_string)
  • GitHub Check: fuzz (dash_deserialize_address)
  • GitHub Check: fuzz (dash_deser_net_msg)
  • GitHub Check: fuzz (dash_deserialize_amount)
  • GitHub Check: Core Components Tests
  • GitHub Check: RPC Tests (stable, true)
  • GitHub Check: Strict Warnings and Clippy Checks
  • GitHub Check: SPV Components Tests
  • GitHub Check: Key Wallet Components Tests
🔇 Additional comments (1)
.github/workflows/rust.yml (1)

23-23: Original concern outdated: ubuntu-22.04-arm is now a valid, officially-supported GitHub Actions runner.

The ubuntu-22.04-arm runner is a standard GitHub-hosted runner label available for Arm64 development. As of January 2025, Linux arm64 hosted runners are now available in public repositories as part of GitHub Actions. These runners are free for public repositories and provide developers with efficient tools for building and testing software on Arm-based architectures.

For public repositories, this change is safe and requires no action. For private repositories, workflows using these labels will only function on Team and Enterprise Cloud plans—verify your plan supports Arm runners if applicable.

The infrastructure change is legitimate and properly configured. No issues found.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants