Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix #684 : allow edit for a DAG with . in the name #767

Merged
merged 5 commits into from
Jan 3, 2025

omit license header from each file

d5ab924
Select commit
Loading
Failed to load commit list.
Merged

ui: fix #684 : allow edit for a DAG with . in the name #767

omit license header from each file
d5ab924
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2025 in 0s

55.40% (-0.05%) compared to f517ce2

View this Pull Request on Codecov

55.40% (-0.05%) compared to f517ce2

Details

Codecov Report

Attention: Patch coverage is 21.21212% with 26 lines in your changes missing coverage. Please review.

Project coverage is 55.40%. Comparing base (f517ce2) to head (d5ab924).

Files with missing lines Patch % Lines
internal/digraph/builder.go 0.00% 17 Missing ⚠️
internal/persistence/local/dag_store.go 0.00% 6 Missing ⚠️
internal/config/loader.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   55.45%   55.40%   -0.05%     
==========================================
  Files          69       69              
  Lines        7145     7151       +6     
==========================================
  Hits         3962     3962              
- Misses       2849     2854       +5     
- Partials      334      335       +1     
Files with missing lines Coverage Δ
cmd/dry.go 68.00% <ø> (ø)
cmd/main.go 76.66% <100.00%> (ø)
cmd/restart.go 53.57% <ø> (ø)
cmd/retry.go 54.05% <ø> (ø)
cmd/scheduler.go 65.85% <ø> (ø)
cmd/server.go 80.88% <ø> (ø)
cmd/setup.go 76.08% <ø> (ø)
cmd/start.go 62.72% <ø> (ø)
cmd/start_all.go 42.00% <ø> (ø)
cmd/status.go 59.45% <ø> (ø)
... and 58 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f517ce2...d5ab924. Read the comment docs.