Fix: exclude inactive apps from search index#125
Open
kushvinth wants to merge 1 commit intocytoscape:masterfrom
Open
Fix: exclude inactive apps from search index#125kushvinth wants to merge 1 commit intocytoscape:masterfrom
kushvinth wants to merge 1 commit intocytoscape:masterfrom
Conversation
The search index was including all apps regardless of their active status, but the detail view requires active=True. This caused search results for inactive apps (e.g. keggscape, cytokegg) to link to 404 pages. Override index_queryset() in AppIndex to restrict indexing to active apps only, ensuring search results only contain apps that can be viewed.
Author
|
PTAL @coleslaw481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces a small but important change to the
AppIndexsearch index. The change ensures that only activeAppobjects are included in the search index.AppIndexclass inapps/search_indexes.pyto filter the queryset so that onlyAppobjects withactive=Trueare indexed.Related Issues